C++: Update expected test results after extractor changes#21208
Merged
Conversation
jketema
added
the
depends on internal PR
jketema
force-pushed
the
jketema/softfloat
branch
from
3cd2231 to
43fb29c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates expected test results in C++ query tests to reflect changes in how the extractor formats floating-point numbers. The extractor now uses scientific notation (e.g., 3.5E15) instead of full decimal representation (e.g., 3500000000000000.0) for large numbers, and shorter decimal representations (e.g., 2.71828) instead of high-precision formats (e.g., 2.71828000000000003) for regular floating-point values.
Changes:
- Updated floating-point literal representations to use scientific notation for large values
- Updated floating-point literal representations to use shorter decimal formats for regular values
- Added sequential line numbers where they were previously missing in test expectations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/query-tests/Likely Bugs/Underspecified Functions/MistypedFunctionArguments.expected | Updated floating-point literal formats and added missing line numbers for test expectations |
| cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/nrOfBounds.expected | Updated floating-point literal formats to shorter decimal representations and added missing line numbers |
| cpp/ql/test/library-tests/controlflow/guards/GuardsEnsure.expected | Updated floating-point literal format for small scientific notation value and added missing line numbers |
| cpp/ql/test/library-tests/controlflow/guards/GuardsCompare.expected | Updated floating-point literal format for small scientific notation value and added missing line numbers |
| cpp/ql/test/library-tests/builtins/complex/builtin.expected | Updated floating-point literal formats to shorter decimal representations and added missing line numbers |
geoffw0
previously approved these changes
Feb 20, 2026
geoffw0
left a comment
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
Looks great! (assuming tests pass on the corresponding branch)
Contributor
Author
They do. |
jketema
force-pushed
the
jketema/softfloat
branch
from
43fb29c to
a935d97
Compare
tausbn
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.