Merge branch next and update CodeQL#1154
Open
mbaluda wants to merge 104 commits into
Open
Conversation
Observe that `sizeof(...)` might not occur as a dataflow node if it has a parent node with a concrete value. That value will be a dataflow node instead. Hence, the query has be changed to check for expressions where `sizeof(...)` is a child of an expression with a concrete value.
Note that we now properly report the offending cast instead of the expression that is being cast.
As it is the dataflow used by `asctime` that is relevant, and not the pointer, use the indirect expression.
These use the new dataflow library
Since the new dataflow library uses use-use dataflow and not def-use dataflow, we now need to check for definitions. Note that these queries can probably be improved by using a dataflow configuration - possibly limited to the local context of a function by including `DataFlow::FeatureEqualSourceSinkCallContext`
…ataflow library" This reverts commit b18c7b4. This change broke some tests.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the repository’s CodeQL toolchain and pack dependencies (notably moving to CodeQL CLI 2.23.3 and codeql/cpp-all 6.0.0), while updating many C/C++ coding-standards queries to newer dataflow/taint-tracking and concurrency libraries. It also refreshes a large set of unit test .expected outputs and adds a change note documenting the version bump and query behavior adjustments.
Changes:
- Bump supported CodeQL environment to
2.23.3and update CodeQL pack dependencies/locks (includingcodeql/cpp-all: 6.0.0). - Migrate many queries and shared libraries from deprecated dataflow/taint-tracking/concurrency modules to
...dataflow.new...andConcurrencyNew. - Update unit tests and
.expectedfiles to reflect changed query outputs; add a change note for the upgrade.
Checklist items uncertain (not confirmed in this review):
- Shared query format validation in VS Code (per PR checklist).
- Performance/result validation on OpenPilot (per PR checklist).
Show a summary per file
| File | Description |
|---|---|
| supported_codeql_configs.json | Updates supported CodeQL CLI/stdlib/bundle versions to 2.23.3. |
| scripts/generate_modules/queries/qlpack.yml | Bumps extraction pack dependency to codeql/cpp-all: 6.0.0. |
| scripts/generate_modules/queries/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for extraction pack. |
| cpp/report/src/qlpack.yml | Bumps report pack dependency to codeql/cpp-all: 6.0.0. |
| cpp/report/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for report pack. |
| cpp/misra/test/rules/RULE-8-2-8/test.cpp | Adjusts compliance annotation for template variable cast test. |
| cpp/misra/test/rules/RULE-8-2-8/PointerToIntegralCast.expected | Updates expected results/locations for RULE-8-2-8 tests. |
| cpp/misra/test/rules/RULE-19-2-2/test.cpp | Updates test annotation to remove false-negative marker. |
| cpp/misra/test/rules/RULE-19-2-2/InvalidIncludeDirective.expected | Adds/updates expected result for invalid include directive. |
| cpp/misra/test/rules/RULE-15-1-3/NonExplicitConversionMember.expected | Updates expected conversion-operator name formatting. |
| cpp/misra/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for MISRA C++ tests. |
| cpp/misra/src/rules/RULE-8-7-1/PointerArithmeticFormsAnInvalidPointer.ql | Updates imports/types for new dataflow and SSA internals. |
| cpp/misra/src/rules/RULE-0-1-1/UnnecessaryWriteToLocalObject.ql | Switches to semmle.code.cpp.dataflow.new.DataFlow. |
| cpp/misra/src/qlpack.yml | Bumps MISRA C++ pack dependency to codeql/cpp-all: 6.0.0. |
| cpp/misra/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for MISRA C++ pack. |
| cpp/common/test/rules/throwingoperatornewreturnsnull/ThrowingOperatorNewReturnsNull.expected | Updates path-problem expected output structure. |
| cpp/common/test/rules/movedfromobjectsunspecifiedstate/MovedFromObjectsUnspecifiedState.expected | Updates expected output to match new flow nodes/labels. |
| cpp/common/test/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.expected | Updates expected output to match new flow nodes/labels. |
| cpp/common/test/rules/danglingcapturewhenreturninglambdaobject/DanglingCaptureWhenReturningLambdaObject.expected | Updates expected results to remove duplicate/changed row. |
| cpp/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected | Updates expected output to match new flow nodes/labels. |
| cpp/common/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for common C++ tests. |
| cpp/common/src/qlpack.yml | Bumps common C++ pack dependency to codeql/cpp-all: 6.0.0. |
| cpp/common/src/codingstandards/cpp/standardlibrary/STLContainers.qll | Migrates to new taint tracking; adjusts local taint helper. |
| cpp/common/src/codingstandards/cpp/standardlibrary/FileStreams.qll | Migrates to new taint tracking imports. |
| cpp/common/src/codingstandards/cpp/SmartPointers.qll | Migrates to semmle.code.cpp.dataflow.new.DataFlow. |
| cpp/common/src/codingstandards/cpp/SideEffect.qll | Migrates to semmle.code.cpp.dataflow.new.DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/wrapspuriousfunctioninloop/WrapSpuriousFunctionInLoop.qll | Switches to ConcurrencyNew. |
| cpp/common/src/codingstandards/cpp/rules/useonlyarrayindexingforpointerarithmetic/UseOnlyArrayIndexingForPointerArithmetic.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/unusedtypedeclarations/UnusedTypeDeclarations.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/rules/unsignedoperationwithconstantoperandswraps/UnsignedOperationWithConstantOperandsWraps.qll | Updates guard-condition handling logic. |
| cpp/common/src/codingstandards/cpp/rules/unnecessaryexposedidentifierdeclarationshared/UnnecessaryExposedIdentifierDeclarationShared.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/rules/throwingoperatornewreturnsnull/ThrowingOperatorNewReturnsNull.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/stringnumberconversionmissingerrorcheck/StringNumberConversionMissingErrorCheck.qll | Migrates to new TaintTracking. |
| cpp/common/src/codingstandards/cpp/rules/preventdeadlockbylockinginpredefinedorder/PreventDeadlockByLockingInPredefinedOrder.qll | Switches to ConcurrencyNew. |
| cpp/common/src/codingstandards/cpp/rules/preservesafetywhenusingconditionvariables/PreserveSafetyWhenUsingConditionVariables.qll | Switches to ConcurrencyNew. |
| cpp/common/src/codingstandards/cpp/rules/predicatefunctionobjectsshouldnotbemutable/PredicateFunctionObjectsShouldNotBeMutable.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/placementnewnotproperlyaligned/PlacementNewNotProperlyAligned.qll | Removes deprecated DataFlow import (uses path graph). |
| cpp/common/src/codingstandards/cpp/rules/placementnewinsufficientstorage/PlacementNewInsufficientStorage.qll | Removes deprecated DataFlow import (uses path graph). |
| cpp/common/src/codingstandards/cpp/rules/ownedpointervaluestoredinunrelatedsmartpointer/OwnedPointerValueStoredInUnrelatedSmartPointer.qll | Migrates to new TaintTracking. |
| cpp/common/src/codingstandards/cpp/rules/onlyfreememoryallocateddynamicallyshared/OnlyFreeMemoryAllocatedDynamicallyShared.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/nonvoidfunctiondoesnotreturn/NonVoidFunctionDoesNotReturn.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/rules/nonconstantformat/NonConstantFormat.qll | Migrates to new TaintTracking. |
| cpp/common/src/codingstandards/cpp/rules/multipleglobalormemberdeclarators/MultipleGlobalOrMemberDeclarators.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/rules/movedfromobjectsunspecifiedstate/MovedFromObjectsUnspecifiedState.qll | Migrates to new DataFlow and updates flow logic. |
| cpp/common/src/codingstandards/cpp/rules/joinordetachthreadonlyonce/JoinOrDetachThreadOnlyOnce.qll | Switches to ConcurrencyNew. |
| cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll | Removes deprecated TaintTracking import (via shared libs). |
| cpp/common/src/codingstandards/cpp/rules/invalidatedenvstringpointers/InvalidatedEnvStringPointers.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/guardaccesstobitfields/GuardAccessToBitFields.qll | Switches to ConcurrencyNew. |
| cpp/common/src/codingstandards/cpp/rules/functionerroneousreturnvaluenottested/FunctionErroneousReturnValueNotTested.qll | Migrates to new DataFlow and updates guard-detection logic. |
| cpp/common/src/codingstandards/cpp/rules/donotuserelationaloperatorswithdifferingarrays/DoNotUseRelationalOperatorsWithDifferingArrays.qll | Migrates to new DataFlow and adds barrier handling. |
| cpp/common/src/codingstandards/cpp/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.qll | Migrates to new DataFlow and adds barrier handling. |
| cpp/common/src/codingstandards/cpp/rules/donotpassaliasedpointertorestrictqualifiedparamshared/DoNotPassAliasedPointerToRestrictQualifiedParamShared.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/donotaccessaclosedfile/DoNotAccessAClosedFile.qll | Migrates to new DataFlow and updates local-flow node usage. |
| cpp/common/src/codingstandards/cpp/rules/danglingcapturewhenreturninglambdaobject/DanglingCaptureWhenReturningLambdaObject.qll | Migrates to new DataFlow and updates lambda-to-return flow. |
| cpp/common/src/codingstandards/cpp/rules/danglingcapturewhenmovinglambdaobject/DanglingCaptureWhenMovingLambdaObject.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/containeraccesswithoutrangecheck/ContainerAccessWithoutRangeCheck.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/constlikereturnvalue/ConstLikeReturnValue.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/rules/basicstringmaynotbenullterminated/BasicStringMayNotBeNullTerminated.qll | Migrates to new taint tracking and updates node usage. |
| cpp/common/src/codingstandards/cpp/ReadErrorsAndEOF.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/Overflow.qll | Adjusts imports (notably dataflow/taint tracking). |
| cpp/common/src/codingstandards/cpp/OutOfBounds.qll | Removes deprecated DataFlow import (relies on other modules). |
| cpp/common/src/codingstandards/cpp/MistypedFunctionArguments.qll | Simplifies recursion for “compiled as C” detection. |
| cpp/common/src/codingstandards/cpp/Loops.qll | Updates unknown-location handling types. |
| cpp/common/src/codingstandards/cpp/Iterators.qll | Migrates to new TaintTracking and updates imports. |
| cpp/common/src/codingstandards/cpp/Identifiers.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/FgetsErrorManagement.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/Expr.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/deadcode/UnusedVariables.qll | Updates template-parameter type usage for newer libs. |
| cpp/common/src/codingstandards/cpp/ConstHelpers.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/ConcurrencyNew.qll | Adds a new umbrella module for updated concurrency modeling. |
| cpp/common/src/codingstandards/cpp/concurrency/ThreadSpecificStorageNew.qll | Adds new thread-specific storage modeling using new dataflow. |
| cpp/common/src/codingstandards/cpp/Allocations.qll | Migrates to new DataFlow. |
| cpp/common/src/codingstandards/cpp/AccessPath.qll | Migrates to new DataFlow. |
| cpp/common/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for common C++ pack. |
| cpp/cert/test/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.expected | Removes deprecated-module warning from expected output. |
| cpp/cert/test/rules/MEM52-CPP/DetectAndHandleMemoryAllocationErrors.expected | Removes deprecated-module warnings from expected output. |
| cpp/cert/test/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.expected | Updates expected path-problem output structure. |
| cpp/cert/test/rules/CTR53-CPP/UseValidIteratorRanges.expected | Removes deprecated-module warnings from expected output. |
| cpp/cert/test/rules/CTR52-CPP/GuaranteeGenericCppLibraryFunctionsDoNotOverflow.expected | Removes deprecated-module warnings from expected output. |
| cpp/cert/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for CERT C++ tests. |
| cpp/cert/src/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.ql | Migrates to new TaintTracking. |
| cpp/cert/src/rules/MEM52-CPP/DetectAndHandleMemoryAllocationErrors.ql | Migrates to new DataFlow and updates guard detection. |
| cpp/cert/src/rules/EXP50-CPP/DoNotDependOnTheOrderOfScalarObjectEvaluationForSideEffects.ql | Fixes typo/formatting in alert message. |
| cpp/cert/src/rules/EXP50-CPP/DoNotDependOnTheOrderOfEvaluationForSideEffectsInFunctionCallsAsFunctionArguments.ql | Adjusts imports (removes redundant DataFlow import). |
| cpp/cert/src/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.ql | Migrates to new DataFlow. |
| cpp/cert/src/rules/CTR55-CPP/DoNotUseAnAdditiveOperatorOnAnIterator.ql | Updates expression handling for guard checks. |
| cpp/cert/src/rules/CTR53-CPP/UseValidIteratorRanges.ql | Migrates to new DataFlow. |
| cpp/cert/src/rules/CTR52-CPP/GuaranteeGenericCppLibraryFunctionsDoNotOverflow.ql | Migrates to new TaintTracking. |
| cpp/cert/src/rules/CON56-CPP/LockedALockedNonRecursiveMutexAudit.ql | Switches to ConcurrencyNew. |
| cpp/cert/src/rules/CON56-CPP/DoNotSpeculativelyLockALockedNonRecursiveMutex.ql | Switches to ConcurrencyNew. |
| cpp/cert/src/qlpack.yml | Bumps CERT C++ pack dependency to codeql/cpp-all: 6.0.0. |
| cpp/cert/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for CERT C++ pack. |
| cpp/autosar/test/rules/M9-3-1/ConstMemberFunctionReturnsNonConstPointer.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/M3-9-3/UnderlyingBitRepresentationsOfFloatingPointValuesUsed.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A9-3-1/ReturnsNonConstRawPointersOrReferencesToPrivateOrProtectedData.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A8-4-9/InOutParametersDeclaredAsTNotModified.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A8-4-12/UniquePtrPassedToFunctionWithImproperSemantics.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A8-4-11/SmartPointerAsParameterWithoutLifetimeSemantics.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A7-5-1/InvalidFunctionReturnType.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A5-1-7/LambdaPassedToTypeid.expected | Updates expected path-problem output structure. |
| cpp/autosar/test/rules/A5-1-7/LambdaPassedToDecltype.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A5-0-4/PointerArithmeticUsedWithPointersToNonFinalClasses.expected | Updates expected path-problem output structure. |
| cpp/autosar/test/rules/A27-0-4/CStyleStringsUsed.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A20-8-4/SharedPointerUsedWithNoOwnershipSharing.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A18-9-4/ArgumentToForwardSubsequentlyUsed.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A15-2-2/ConstructorErrorLeavesObjectInInvalidState.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A15-1-3/ThrownExceptionsShouldBeUnique.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A13-5-3/UserDefinedConversionOperatorsShouldNotBeUsed.expected | Updates expected operator-string formatting. |
| cpp/autosar/test/rules/A13-2-1/AssignmentOperatorReturnThis.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/rules/A13-1-3/UserDefinedLiteralsOperatorsShallOnlyPerformConversionOfPassedParameters.expected | Removes deprecated-module warnings from expected output. |
| cpp/autosar/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for AUTOSAR C++ tests. |
| cpp/autosar/src/rules/M9-3-1/ConstMemberFunctionReturnsNonConstPointer.ql | Migrates to new DataFlow and updates local-flow node usage. |
| cpp/autosar/src/rules/M5-0-17/PointerSubtractionOnDifferentArrays.ql | Migrates to new DataFlow and adds barrier handling. |
| cpp/autosar/src/rules/M3-9-3/UnderlyingBitRepresentationsOfFloatingPointValuesUsed.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A9-3-1/ReturnsNonConstRawPointersOrReferencesToPrivateOrProtectedData.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A8-4-9/InOutParametersDeclaredAsTNotModified.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A8-4-12/UniquePtrPassedToFunctionWithImproperSemantics.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A8-4-11/SmartPointerAsParameterWithoutLifetimeSemantics.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A7-5-1/InvalidFunctionReturnType.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A5-1-7/LambdaPassedToTypeid.ql | Migrates to new DataFlow and updates sink-node selection. |
| cpp/autosar/src/rules/A5-1-7/LambdaPassedToDecltype.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A5-0-4/PointerArithmeticUsedWithPointersToNonFinalClasses.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A4-7-1/IntegerExpressionLeadToDataLoss.ql | Updates guard-condition handling logic. |
| cpp/autosar/src/rules/A27-0-4/CStyleStringsUsed.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A20-8-4/SharedPointerUsedWithNoOwnershipSharing.ql | Migrates to new DataFlow and updates local-flow node usage. |
| cpp/autosar/src/rules/A18-9-4/ArgumentToForwardSubsequentlyUsed.ql | Migrates to new DataFlow and updates defining-argument usage. |
| cpp/autosar/src/rules/A15-2-2/ConstructorErrorLeavesObjectInInvalidState.ql | Migrates to new DataFlow and introduces dedicated new/delete flow config. |
| cpp/autosar/src/rules/A15-1-3/ThrownExceptionsShouldBeUnique.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A13-2-1/AssignmentOperatorReturnThis.ql | Migrates to new DataFlow. |
| cpp/autosar/src/rules/A13-1-3/UserDefinedLiteralsOperatorsShallOnlyPerformConversionOfPassedParameters.ql | Migrates to new TaintTracking. |
| cpp/autosar/src/qlpack.yml | Bumps AUTOSAR C++ pack dependency to codeql/cpp-all: 6.0.0. |
| cpp/autosar/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for AUTOSAR C++ pack. |
| change_notes/2026-06-25-upgrade-to-2.23.3.md | Adds change note documenting the CodeQL upgrade and query changes. |
| c/misra/test/rules/RULE-22-7/EofShallBeComparedWithUnmodifiedReturnValues.expected | Removes deprecated-module warnings from expected output. |
| c/misra/test/rules/RULE-22-4/AttemptToWriteToAReadOnlyStream.expected | Removes deprecated-module warnings from expected output. |
| c/misra/test/rules/RULE-22-3/FileOpenForReadAndWriteOnDifferentStreams.expected | Removes deprecated-module warnings from expected output. |
| c/misra/test/rules/RULE-2-4/UnusedTagDeclaration.expected | Updates expected output (removes one result). |
| c/misra/test/rules/RULE-2-4/test.c | Adjusts compliant annotation text/wrapping. |
| c/misra/test/rules/RULE-17-5/ArrayFunctionArgumentNumberOfElements.expected | Removes deprecated-module warnings from expected output. |
| c/misra/test/rules/RULE-13-2/UnsequencedAtomicReads.expected | Removes deprecated-module warnings from expected output. |
| c/misra/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for MISRA C tests. |
| c/misra/src/rules/RULE-22-7/EofShallBeComparedWithUnmodifiedReturnValues.ql | Migrates to new DataFlow. |
| c/misra/src/rules/RULE-22-4/AttemptToWriteToAReadOnlyStream.ql | Migrates to new DataFlow. |
| c/misra/src/rules/RULE-22-3/FileOpenForReadAndWriteOnDifferentStreams.ql | Migrates to new DataFlow. |
| c/misra/src/rules/RULE-22-20/ThreadStoragePointerInitializedInsideThread.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-20/ThreadStorageNotInitializedBeforeUse.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-19/ConditionVariableUsedWithMultipleMutexes.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLockedAudit.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLocked.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-15/ThreadResourceDisposedBeforeThreadsJoined.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-14/MutexNotInitializedBeforeUse.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-14/MutexInitWithInvalidMutexType.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-14/MutexInitializedInsideThread.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-13/ThreadingObjectWithInvalidStorageDuration.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-22-12/NonstandardUseOfThreadingObject.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-21-14/MemcmpUsedToCompareNullTerminatedStrings.ql | Migrates to new TaintTracking and updates node conversions. |
| c/misra/src/rules/RULE-18-6/ThreadLocalObjectAddressCopiedToGlobalObject.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/RULE-17-5/ArrayFunctionArgumentNumberOfElements.ql | Migrates to new DataFlow and updates sink-node selection. |
| c/misra/src/rules/RULE-13-2/UnsequencedAtomicReads.ql | Migrates to new TaintTracking. |
| c/misra/src/rules/DIR-5-3/ThreadCreatedByThread.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/DIR-5-3/BannedDynamicThreadCreation.ql | Switches to ConcurrencyNew. |
| c/misra/src/rules/DIR-5-1/PossibleDataRaceBetweenThreads.ql | Updates imports to use ConcurrencyNew and refactors module deps. |
| c/misra/src/qlpack.yml | Bumps MISRA C pack dependency to codeql/cpp-all: 6.0.0. |
| c/misra/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for MISRA C pack. |
| c/common/test/rules/onlyfreememoryallocateddynamicallyshared/OnlyFreeMemoryAllocatedDynamicallyShared.expected | Updates expected path-problem output structure. |
| c/common/test/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.expected | Updates expected path-problem output structure. |
| c/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected | Updates expected path-problem output structure. |
| c/common/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for common C tests. |
| c/common/src/qlpack.yml | Bumps common C pack dependency to codeql/cpp-all: 6.0.0. |
| c/common/src/codingstandards/c/Signal.qll | Migrates to new DataFlow. |
| c/common/src/codingstandards/c/OutOfBounds.qll | Removes deprecated DataFlow import (relies on other modules). |
| c/common/src/codingstandards/c/initialization/GlobalInitializationAnalysis.qll | Switches to ConcurrencyNew. |
| c/common/src/codingstandards/c/Extensions.qll | Updates extension detection logic for real-type extensions. |
| c/common/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for common C pack. |
| c/cert/test/rules/STR31-C/StringsHasSufficientSpaceForTheNullTerminator.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/SIG35-C/DoNotReturnFromAComputationalExceptionHandler.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/MSC33-C/DoNotPassInvalidDataToTheAsctimeFunction.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.expected | Updates expected path-problem output structure. |
| c/cert/test/rules/MEM35-C/InsufficientMemoryAllocatedForObject.expected | Updates expected output (includes remaining deprecation warnings). |
| c/cert/test/rules/INT31-C/test.c | Updates compliance annotations for integer conversion tests. |
| c/cert/test/rules/INT31-C/IntegerConversionCausesDataLoss.expected | Adds expected findings for new/adjusted INT31-C cases. |
| c/cert/test/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/FIO40-C/ResetStringsOnFgetsOrFgetwsFailure.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.expected | Updates expected messages for EXP37-C. |
| c/cert/test/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/ERR30-C/SetlocaleMightSetErrno.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/ERR30-C/ErrnoReadBeforeReturn.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.expected | Updates expected output structure/locations. |
| c/cert/test/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/CON34-C/AppropriateThreadObjectStorageDurations.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/CON30-C/CleanUpThreadSpecificStorage.expected | Removes deprecated-module warnings from expected output. |
| c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.expected | Updates expected path-problem output structure. |
| c/cert/test/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.expected | Updates expected path-problem output structure. |
| c/cert/test/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for CERT C tests. |
| c/cert/src/rules/STR31-C/StringsHasSufficientSpaceForTheNullTerminator.ql | Migrates to new TaintTracking. |
| c/cert/src/rules/SIG35-C/DoNotReturnFromAComputationalExceptionHandler.ql | Migrates to new DataFlow. |
| c/cert/src/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql | Migrates to new DataFlow. |
| c/cert/src/rules/MSC33-C/DoNotPassInvalidDataToTheAsctimeFunction.ql | Migrates to new DataFlow and updates sink modeling. |
| c/cert/src/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.ql | Migrates to new DataFlow. |
| c/cert/src/rules/MEM35-C/InsufficientMemoryAllocatedForObject.ql | Adjusts imports (removes deprecated TaintTracking direct import). |
| c/cert/src/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.ql | Migrates to new DataFlow. |
| c/cert/src/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql | Migrates to new DataFlow and updates by-ref argument nodes. |
| c/cert/src/rules/FIO40-C/ResetStringsOnFgetsOrFgetwsFailure.ql | Migrates to new DataFlow. |
| c/cert/src/rules/FIO37-C/SuccessfulFgetsOrFgetwsMayReturnAnEmptyString.ql | Migrates to new DataFlow. |
| c/cert/src/rules/EXP40-C/DoNotModifyConstantObjects.ql | Migrates to new DataFlow. |
| c/cert/src/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.ql | Updates alert message text and formatting. |
| c/cert/src/rules/EXP37-C/DoNotCallFunctionPointerWithIncompatibleType.ql | Migrates to new DataFlow and adds type mismatch guard. |
| c/cert/src/rules/EXP36-C/DoNotCastPointerToMoreStrictlyAlignedPointerType.ql | Migrates to new DataFlow. |
| c/cert/src/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.ql | Migrates to new TaintTracking. |
| c/cert/src/rules/EXP16-C/DoNotCompareFunctionPointersToConstantValues.ql | Updates guard-condition modeling for implicit comparisons. |
| c/cert/src/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.ql | Migrates to new DataFlow. |
| c/cert/src/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.ql | Migrates to new DataFlow. |
| c/cert/src/rules/ERR30-C/SetlocaleMightSetErrno.ql | Migrates to new DataFlow. |
| c/cert/src/rules/ERR30-C/ErrnoReadBeforeReturn.ql | Migrates to new DataFlow. |
| c/cert/src/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.ql | Migrates to new DataFlow and updates sink modeling. |
| c/cert/src/rules/CON41-C/WrapFunctionsThatCanFailSpuriouslyInLoop.ql | Switches to ConcurrencyNew. |
| c/cert/src/rules/CON40-C/AtomicVariableTwiceInExpression.ql | Switches to ConcurrencyNew. |
| c/cert/src/rules/CON37-C/DoNotCallSignalInMultithreadedProgram.ql | Switches to ConcurrencyNew. |
| c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql | Switches to ConcurrencyNew and migrates to new DataFlow. |
| c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql | Switches to ConcurrencyNew and migrates to new DataFlow. |
| c/cert/src/rules/CON33-C/RaceConditionsWhenUsingLibraryFunctions.ql | Switches to ConcurrencyNew. |
| c/cert/src/rules/CON30-C/CleanUpThreadSpecificStorage.ql | Switches to ConcurrencyNew and migrates to new DataFlow; updates barriers. |
| c/cert/src/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.ql | Migrates to new TaintTracking and adjusts scaled-integer detection. |
| c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql | Migrates to new DataFlow. |
| c/cert/src/qlpack.yml | Bumps CERT C pack dependency to codeql/cpp-all: 6.0.0. |
| c/cert/src/codeql-pack.lock.yml | Refreshes locked CodeQL dependency versions for CERT C pack. |
Review details
Comments suppressed due to low confidence (1)
c/common/src/codingstandards/c/Extensions.qll:127
CRealTypeExtensionExtensionnow matchesFloat128Type, but the diagnostic message still says "Decimal floats". This will produce misleading results for users.
- Files reviewed: 244/244 changed files
- Comments generated: 5
- Review effort level: Low
This reverts commit 012ac3d.
|
🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request upgrades CodeQL dependencies, updates dataflow and concurrency imports to use newer modules, and refines several rule implementations for improved accuracy and maintainability. The changes ensure compatibility with the latest CodeQL libraries and enhance the precision of certain queries.
Dependency and Import Updates:
codeql/cpp-alland several other CodeQL dependencies to their latest versions inqlpack.ymlandcodeql-pack.lock.yml, ensuring compatibility with recent CodeQL features. [1] [2]semmle.code.cpp.dataflow.DataFlowand related imports withsemmle.code.cpp.dataflow.new.DataFlowandsemmle.code.cpp.dataflow.new.TaintTrackingacross multiple rules for improved dataflow analysis. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]codingstandards.cpp.Concurrencytocodingstandards.cpp.ConcurrencyNewfor improved concurrency analysis in relevant rules. [1] [2] [3] [4] [5] [6] [7]These updates include changes from the
nextbranch to maintain compatibility with the evolving CodeQL ecosystem.Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.