Removing the latent labels from the old branching setup#2130
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two legacy PR-intent labels from the repository’s label management workflows, aligning labeling automation with the current (non-legacy) branching/labeling model.
Changes:
- Removes the
targets-mainandbranched-mainlabel definitions from the repository label setup workflow. - Removes
targets-main/branched-mainfrom PR intent labeling logic, including the old path-based detection forbranched-main. - Simplifies the PR labeling flow to apply category labels directly based on file-path patterns.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/setup-labels.yml |
Stops creating/updating the legacy targets-main and branched-main labels. |
.github/workflows/label-pr-intent.yml |
Removes legacy label management and the special-case branched-main detection logic from PR labeling. |
Review details
Comments suppressed due to low confidence (1)
.github/workflows/label-pr-intent.yml:26
- Removing
targets-main/branched-mainfrommanagedLabelsmeans the workflow will no longer remove these legacy labels from existing PRs, so they can linger indefinitely even though the repo has stopped applying them. If the goal is to fully retire these labels, keep them inmanagedLabels(but do not add them todesiredLabels) so the workflow automatically cleans them up over time.
const managedLabels = {
'skills': true,
'plugin': true,
'agent': true,
'instructions': true,
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing some missed legacy labelling