Add Trace2 instrumentation to Entra authentication - #2450
Merged
Merged
Conversation
mjcheetham
force-pushed
the
trace2-entra
branch
from
September 18, 2026 12:04
0b3e02a to
8d23083
Compare
dscho
approved these changes
Sep 23, 2026
Comment on lines
-107
to
+113
| var availableNames = available.Select(m => m.ToString().ToLowerInvariant()); | ||
| var availableNames = available.Select(GetModeName); |
Contributor
There was a problem hiding this comment.
This change puzzled me for a moment, until I figured out that GetModeName() is a named variant of that closure. Therefore this change is appropriate.
Entra has the most branching of any authentication path in GCM: broker or not, silent or interactive, and within interactive one of three modes - each selected by some combination of user setting, stored preference, platform support and runtime availability. When someone reports that authentication did something unexpected, the answer is almost always one of those decisions, and none of them left a trace that could be correlated with timings. Assisted-by: Claude Opus 5 Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
force-pushed
the
trace2-entra
branch
from
September 23, 2026 11:13
8d23083 to
26e67a3
Compare
mjcheetham
marked this pull request as ready for review
September 23, 2026 11:14
mjcheetham
enabled auto-merge
September 23, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires git-ecosystem/git-credential-manager#2451 be merged first!
Add Trace2-based instrumentation around all aspects of Entra authentication.
Entra has the most branching of any authentication path in GCM: broker or not, silent or interactive, and within interactive one of three modes - each selected by some combination of user setting, stored preference, platform support and runtime availability. When someone reports that authentication did something unexpected, the answer is almost always one of those decisions, and none of them left a trace that could be correlated with timings.