generic: permit any protocol for generic OAuth config - #2445
Merged
mjcheetham merged 1 commit intoSep 16, 2026
Merged
Conversation
We currently od not consider either Windows Integrated or generic OAuth authentication in the generic provider, for a non-HTTP based remote URL. Since GCM can be called as a credential helper by Git for things such as an SMTP server (see `git sendmail`), where the SMTP server may use OAuth authentication, we should relax this restriction. Note that we still require HTTP(S) remotes for Windows Integrated auth since the probe for that requires an HTTP(S) call. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
force-pushed
the
any-protocol-generic-oauth
branch
from
September 16, 2026 14:25
95f2928 to
9e2e539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently do not consider either Windows Integrated or generic OAuth authentication in the generic provider, for a non-HTTP based remote URL.
Since GCM can be called as a credential helper by Git for things such as an SMTP server (see
git sendmail), where the SMTP server may use OAuth authentication, we should relax this restriction.Note that we still require HTTP(S) remotes for Windows Integrated auth since the probe for that requires an HTTP(S) call.
Replaces #1956
Tip
Ignore whitespace when reviewing the diff in the
GenericHostProvider.csfile - we are adding a wrappingif () { }block to existing code.