notifications Novu#361
Conversation
- Add @novu/react and @novu/js v3.16.0 to apps/web/package.json - Create NovuNotificationsProvider component in apps/web/components/providers/ - Integrate NovuProvider and Inbox bell into dashboard sidebar (dashboard.ui.tsx) - Add NEXT_PUBLIC_NOVU_APPLICATION_IDENTIFIER and NOVU_API_KEY to .env.example - Migrated from old flat repo structure to monorepo (apps/web/) layout https://claude.ai/code/session_01BCbdM7MDP7GWKUchoNodRh
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the repository by introducing a comprehensive set of AI agent rules and skills in the .agents directory, alongside significant updates to project documentation and configuration files. Key changes include the addition of AGENTS.md, updates to ARCHITECTURE.md and README.md, and adjustments to environment and tool configurations. Reviewers identified a few stale references in the new documentation that need updating due to file deletions and directory renames.
I am having trouble creating individual review comments. Click here to see my feedback.
AGENTS.md (69)
The path .cursor/rules/ was renamed to .agents/rules/. This reference in AGENTS.md should be updated to reflect the new path.
- `.cursor/rules/` - database function and migration rules.
+ `.agents/rules/` - database function and migration rules.
AGENTS.md (168)
The file apps/web/.env.example was removed in this pull request. This reference in AGENTS.md should be updated or removed accordingly.
- For environment variable changes, update `AGENTS.md`, `README.md`,
- `apps/web/.env.example`, and `docs/devops.md` in the same change.
+ For environment variable changes, update `AGENTS.md`, `README.md`, and `docs/devops.md` in the same change.
💡 Codex Reviewsexyvoice/.github/workflows/claude.yml Lines 25 to 28 in ec431a6  Check out PR ref before handling @claude review comments
This new ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ckout ref - Fix stale .cursor/rules/ path → .agents/rules/ in AGENTS.md - Fix claude-review job to checkout PR head SHA on issue_comment events (previously checked out default branch tip, causing review of wrong code) https://claude.ai/code/session_01BCbdM7MDP7GWKUchoNodRh
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces Novu in-app notifications wiring in the apps/web dashboard UI (via a new provider + inbox component), updates the web app’s dependency set accordingly, and adjusts the Claude GitHub Action workflow to checkout the correct PR head SHA when triggered from issue comments.
Changes:
- Add Novu React SDK dependencies and a
NovuNotificationsProviderclient wrapper. - Embed Novu
Inboxinto the dashboard sidebar UI. - Update workflow checkout behavior for
issue_commenttriggers; minor CSS formatting cleanup; extend.env.examplewith Novu-related variables.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks newly added Novu-related dependencies and transitive packages. |
| apps/web/package.json | Adds @novu/js and @novu/react dependencies. |
| apps/web/components/providers/novu-provider.tsx | New client provider component to wrap Novu configuration. |
| apps/web/app/[lang]/(dashboard)/dashboard.ui.tsx | Wraps dashboard UI with provider and renders Novu Inbox in the sidebar header. |
| apps/web/app/globals.css | Formatting cleanup of keyframes/utilities and gradients. |
| apps/web/.env.example | Adds Novu env var placeholders. |
| AGENTS.md | Updates referenced rules directory path to .agents/rules/. |
| .github/workflows/claude.yml | Checks out PR head SHA for issue_comment-triggered runs. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div className="group-data-[collapsible=icon]:hidden"> | ||
| <Inbox /> | ||
| </div> |
| const applicationIdentifier = | ||
| process.env.NEXT_PUBLIC_NOVU_APPLICATION_IDENTIFIER; | ||
|
|
||
| if (!applicationIdentifier) { | ||
| return <>{children}</>; | ||
| } |
|
|
||
| # Novu in-app notifications | ||
| NEXT_PUBLIC_NOVU_APPLICATION_IDENTIFIER=your_novu_app_identifier | ||
| NOVU_API_KEY=novu_api_key_here |
- Only render <Inbox /> when NEXT_PUBLIC_NOVU_APPLICATION_IDENTIFIER is set, preventing a broken Novu context in unconfigured environments - Remove NOVU_API_KEY from .env.example — not wired up server-side yet https://claude.ai/code/session_01BCbdM7MDP7GWKUchoNodRh
gianpaj
changed the title
Summary
This PR restructures the SexyVoice.ai project into a monorepo architecture using Turborepo, migrates the main app into
apps/web, creates a newapps/docsapplication, and adds comprehensive agent skills for development guidance. The project now includes structured documentation for Turborepo, React best practices, Supabase/Postgres, Motion animations, and other development tools.Changes
apps/andpackages/directoriesapps/docswith API reference, feature guides, and searchable documentationAGENTS.md,ARCHITECTURE.md, addedChangelog.md,ROADMAP.md, and GitHub PR template.ckignore,.biomeignore,.markdownlint.yml, and updated GitHub Actions workflowsCLAUDE.md,.env.example, auth pages, dashboard components) and updated Node.js version to 24.9.0How to test
ls -la apps/andls -la packages/directories existcd apps/docs && pnpm install && pnpm build.agents/skills/directoryAGENTS.mdfor updated development guidelines.github/workflows/are properly configuredScope
Checklist
Notes for reviewers
This is a significant structural change that reorganizes the entire project. Key points:
turbo runfrom the root.apps/web/(currently removed, will be re-added in follow-up PR).apps/docsprovides searchable API documentation and guides.The actual application code has been temporarily removed to allow for proper restructuring. This should be restored in a follow-up PR with proper monorepo organization.
https://claude.ai/code/session_01BCbdM7MDP7GWKUchoNodRh