Skip to content

fix(glsl-out): add parens. to atomicSub negation#9924

Open
ErichDonGubler wants to merge 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:issue-9883
Open

fix(glsl-out): add parens. to atomicSub negation#9924
ErichDonGubler wants to merge 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:issue-9883

Conversation

@ErichDonGubler

@ErichDonGubler ErichDonGubler commented Jul 22, 2026

Copy link
Copy Markdown
Member

Connections

Testing

New snapshot test added. Most of this PR is snapshot testing.

Squash or Rebase?

Squash.

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@ErichDonGubler

Copy link
Copy Markdown
Member Author

@zero0zero7, does this fix work for you?

@ErichDonGubler ErichDonGubler added type: bug Something isn't working backend: gles Issues with GLES or WebGL area: naga back-end Outputs of naga shader conversion naga Shader Translator lang: GLSL OpenGL Shading Language area: correctness We're behaving incorrectly labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: correctness We're behaving incorrectly area: naga back-end Outputs of naga shader conversion backend: gles Issues with GLES or WebGL lang: GLSL OpenGL Shading Language naga Shader Translator type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[naga] GLSL backend emits invalid -- token when atomicSub operand starts with a negation

1 participant