Skip to content

fix: skip redundant name_embedding computation in create_entity_node_embeddings #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GraphiteEdgeR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip redundant name_embedding computation in create_entity_node_embeddings #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphiti_core/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,8 +1099,8 @@ def get_saga_node_from_record(record: Any) -> SagaNode:


async def create_entity_node_embeddings(embedder: EmbedderClient, nodes: list[EntityNode]):
# filter out falsey values from nodes
filtered_nodes = [node for node in nodes if node.name]
# Only compute embeddings for nodes that need them (have a name but no existing embedding)
filtered_nodes = [node for node in nodes if node.name and node.name_embedding is None]

if not filtered_nodes:
return
Expand Down
Loading