Fix issue when changing user in exec subcommands#2230
Open
sabre1041 wants to merge 1 commit into
Open
Conversation
felixfontein
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this!
Signed-off-by: Andrew Block <andy.block@gmail.com>
felixfontein
approved these changes
Jun 23, 2026
felixfontein
left a comment
Contributor
There was a problem hiding this comment.
Assuming you did run the root tests (I don't think they run in CI), this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix exec subcommands (
exec-fileandexec-env) to setHOME,USER, andLOGNAMEenvironment variables in the child process when the--userflag is used.Originating Issue
When using
--userto run a child process as a different user,SwitchUser()changes the UID/GID but leaves the environment variables pointing at the original user. This causes the child process to inherit incorrect values forHOME,USER, andLOGNAME, which can break tools that rely on these variables (e.g., resolving~or determining the current user).Example of issue:
Changes
UserEnv()function inexec_unix.gothat looks up the target user and returns the correctHOME,USER, andLOGNAMEenvironment variablesExecWithFile()andExecWithEnv()to capture user environment variables before switching the user, then inject them into the child process environment--useris setUserEnv()on Windows (exec_windows.go) that fatals, consistent with the existingSwitchUser()behaviorexec_unix_test.gocoveringUserEnv()output, process environment isolation, and integration with both exec modes in pristine and non-pristine configurations