ref(deps): Drop hard redis-py-cluster dependency to allow redis>=4#730
Merged
Conversation
redis-py-cluster (EOL) pins redis<4.0.0, so any consumer of
taskbroker-client is transitively blocked from upgrading to redis>=4.1,
where cluster support is built in as redis.RedisCluster.
The package only uses RedisCluster as a type annotation in
scheduler/storage.py (never constructs it), so:
- Import RedisCluster from `redis` when available (>=4.1), falling back
to `rediscluster` for redis<4 installs that opt into the new `cluster`
extra.
- Move redis-py-cluster from a hard dependency to an optional `cluster`
extra so default installs no longer cap redis below 4.
- De-parametrize the `RedisCluster[str] | StrictRedis[str]` annotation:
redis>=4 ships py.typed with non-generic client classes, so the
subscripted form is a type error ("Expected no type arguments"). The
bare union type-checks cleanly on both redis 3.x and 4.x.
Verified: import resolves to redis.cluster.RedisCluster on redis 8.0.1
and falls back to rediscluster on redis 3.4.1; pyright reports 0 errors
on the bare annotation under redis>=4 bundled types.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bddfe55. Configure here.
evanh
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop hard redis-py-cluster dependency to allow redis>=4. Mirrors the behavior of https://github.com/getsentry/sentry-redis-tools/blob/main/sentry_redis_tools/clients.py.