fix: pre-allocate open ports for rebalance integration test#639
Merged
Conversation
markstory
approved these changes
May 15, 2026
|
PR reverted: 0071d96 |
sentry-taskbroker-fast-revert-bot Bot
pushed a commit
that referenced
this pull request
May 18, 2026
This reverts commit 157c0ee. Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flaky rebalance integration test occasionally fails on GHA due to
ADDR_IN_USEon the gRPC port, but always passes consistently locally. Each of the 8 consumers in the test was assigned one gRPC port and restarted 16 times on that same port, with only a 1-second delay between restarts. The closed socket might be staying around longer than the delay and restarted taskbroker is trying to bind on the same port.This PR pre-allocate one gRPC port per (consumer, restart) pair (128 total) at test start and each restart binds a fresh port that has never been used.