security(deps): resolve js-yaml and @babel/core alerts#1328
Merged
Conversation
- js-yaml override >=4.1.1 -> >=4.2.0 <5 (GHSA-h67p-54hq-rp68, #289): quadratic-complexity DoS in merge key handling via repeated aliases - @babel/core override added >=7.29.6 <8 (GHSA-4x5r-pxfx-6jf8, #288): arbitrary file read via sourceMappingURL comment Both overrides are bounded to the current major (js-yaml <5, @babel/core <8) so an unbounded range doesn't pull a major jump (js-yaml 5.x). Verified full build, build:sea, and test suite (188/188).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 678 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 57.62% 57.62% —%
==========================================
Files 49 49 —
Lines 1602 1602 —
Branches 1153 1153 —
==========================================
+ Hits 924 924 —
- Misses 678 678 —
- Partials 123 123 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 2 remaining open Dependabot alerts (both transitive in
pnpm-lock.yaml).sourceMappingURLcomment.Changes
js-yamloverride>=4.1.1→>=4.2.0 <5@babel/coreoverride>=7.29.6 <8Notes
js-yaml <5,@babel/core <8). An unboundedjs-yaml >=4.2.0pulled 5.1.0 (a major jump with breaking changes); capping keeps the minimal patch within 4.x.Verification
pnpm build(full turbo build) ✓pnpm --filter @spotlightjs/spotlight build:sea✓