feat(attributes): Add filter mode#8099
Merged
Merged
Conversation
wmak
commented
Jun 24, 2026
wmak
commented
Member
- This adds support for filter mode to the trace item attributes endpoint so we can change how we filter between hasAny or hasAll
- Depends on feat(attributes): Add filter mode sentry-protos#327
- This adds support for filter mode to the trace item attributes endpoint so we can change how we filter between hasAny or hasAll
phacops
approved these changes
Jun 25, 2026
wmak
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 25, 2026
- This uses filter mode which should mean we get less false negatives when validating fields - Depends on getsentry/snuba#8099
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.