feat(replays): Add segment_names column#8098
Draft
mjq wants to merge 2 commits into
Draft
Conversation
|
This PR has a migration; here is the generated SQL for -- start migrations
-- forward migration replays : 0025_add_segment_names_column
Local op: ALTER TABLE replays_local ON CLUSTER 'cluster_one_sh' ADD COLUMN IF NOT EXISTS segment_names Array(String) AFTER urls;
Distributed op: ALTER TABLE replays_dist ON CLUSTER 'cluster_one_sh' ADD COLUMN IF NOT EXISTS segment_names Array(String) AFTER urls;
-- end forward migration replays : 0025_add_segment_names_column
-- backward migration replays : 0025_add_segment_names_column
Distributed op: ALTER TABLE replays_dist ON CLUSTER 'cluster_one_sh' DROP COLUMN IF EXISTS segment_names;
Local op: ALTER TABLE replays_local ON CLUSTER 'cluster_one_sh' DROP COLUMN IF EXISTS segment_names;
-- end backward migration replays : 0025_add_segment_names_column |
The segment_names column needs an aggregate function since the replays query uses GROUP BY replay_id. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet ready for review.
Fixes REPLAY-934.