Skip to content

Recording (macOS): size the video bitrate from the actual capture, not the 4K ceiling #924

Closed
#930
Closed
Recording (macOS): size the video bitrate from the actual capture, not the 4K ceiling#924
#930
Labels
enhancementNew feature or requeststatus: fixed in mainWork is merged into main but may not be in a downloadable release yet.status: pending releaseMerged change is waiting for a packaged desktop release.
Milestone
v2.0.0

Description

@EtienneLescot
EtienneLescot
opened on Sep 30, 2026

Part of #920 (rank 15). Effort S, risk low.

Problem

  • macOS always asks ScreenCaptureKit's writer for 76.5 Mbit/s, whatever the capture size: useScreenRecorder.ts sends computeBitrate(TARGET_WIDTH, TARGET_HEIGHT), the app's 4K ceiling with the high-frame-rate boost.
  • That is 4.25× the Windows budget for a 1080p capture.
  • Linux had the same bug and fixed it: its request sends no bitrate, and the helper derives it from the size it actually got (see the comment in buildNativeLinuxRequest).

Proposal

  • Same fix as Linux: derive the bitrate in the Swift helper from the real output size (same tiers as computeBitrate), and stop sending the ceiling's bitrate.

Verify

  • Swift unit test for the size → bitrate tiers (runs in the swift-macos-helper CI job).
  • On a Mac: ffprobe bitrate of a 1080p take, before and after. Expected 2 to 4× smaller files below 4K.

Activity

  1. EtienneLescot
    added
    enhancementNew feature or request
    on Sep 30, 2026
  2. EtienneLescot
    added a parent issue on Sep 30, 2026
  3. EtienneLescot
    closed this as completedin #930on Sep 30, 2026
  4. github-actions
    added
    status: fixed in mainWork is merged into main but may not be in a downloadable release yet.
    status: pending releaseMerged change is waiting for a packaged desktop release.
    on Sep 30, 2026
  5. github-actions
    added this to the Next Release milestone on Sep 30, 2026

  6. github-actions commented on Sep 30, 2026

    @github-actions
    github-actionsbot
    on Sep 30, 2026 – with GitHub Actions
    Contributor

    Fixed by #930 and merged into main.

    This change is assigned to the Next Release release milestone and is not necessarily available in the latest downloadable desktop release yet. It is currently marked as status: pending release until a packaged release containing it is published.

  7. EtienneLescot
    modified the milestones: Next Release, v2.0.0 on Sep 30, 2026

  8. EtienneLescot commented on Sep 30, 2026

    @EtienneLescot
    EtienneLescot
    on Sep 30, 2026
    CollaboratorAuthor

    Moved into v2.0.0 as part of the pre-release cut.

  9. Guo-astro
    added a commit that references this issue on Oct 1, 2026

    fix(macos): size the video bitrate from the actual capture, not the 4…

    a4d92a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requeststatus: fixed in mainWork is merged into main but may not be in a downloadable release yet.status: pending releaseMerged change is waiting for a packaged desktop release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions