This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Adding back button in settings activity and confirmation dialog in main activity#373
Open
htg2704 wants to merge 10 commits into
Open
Adding back button in settings activity and confirmation dialog in main activity#373htg2704 wants to merge 10 commits into
htg2704 wants to merge 10 commits into
Conversation
huangyz0918
suggested changes
Mar 22, 2020
Contributor
|
@htg2704 are you still working on this? |
Author
|
@Chromicle I made a commit 20 days back. I will see why it's not passing the test because according to me I made all necessary changes. |
Contributor
|
yeah, but you build is failing due to pmd check, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #372
Closes #369
What has been done to verify that this works as intended?
Verified on a physical device.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Better user experience.
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes