This repository was archived by the owner on Apr 9, 2021. It is now read-only.
fix: list only smart phones for scanning bluetooth devices#349
Open
ajay-prabhakar wants to merge 1 commit into
Open
fix: list only smart phones for scanning bluetooth devices#349ajay-prabhakar wants to merge 1 commit into
ajay-prabhakar wants to merge 1 commit into
Conversation
Contributor
Author
|
@lakshyagupta21 can you please review my PR's if you are free |
huangyz0918
reviewed
Feb 3, 2020
huangyz0918
left a comment
Contributor
There was a problem hiding this comment.
I have a question @Chromicle , have you test for the android tablets? Is the change disable the tablets?
4e3a15d to
f223b1c
Compare
Contributor
Author
@huangyz0918 My friend checked and he said it is showing as expected @lakshyagupta21 I added the check for NPE, can you please review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #346
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
With the help of
BluetoothClasschecked if the device is the smartphone then added into Bluetooth device list with help of if the conditionHow does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
By adding this fix user can directly select the device to transfer forms
GIF
list of devices before this feature

list of devices after this feature

Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes