UI: disabled the positive button for null validation and made default hotspot name as device name

[ajay-prabhakar]

Closes #347 #136

What has been done to verify that this works as intended?

• Checked whether the positive button is disabling when the length of the text is null
• Checked any new warnings are producing or failing any tests, working perfectly as expected
• Checked by changing the orientation
• Checked the default name for the hotspot is device name or not

Why is this the best possible solution? Were any other approaches considered?

I implemented the editTextWatcher to check for every text change
In the method of onEditTextChanged checked if the length of the editText is zero then I am disabling the positive button of the alert dialog, and I wrote the tests according to that
I made the one more change that I changed the CheckBoxPreference to SwitchPreference as according to material design switches are used to toggle the state of a single setting on or off and checkboxes are used for select one or more items from a set like selecting the forms

For default name of hotspot as @shobhitagarwal1612 suggested I made that as skunkworks-crow deviceName in my case it is skunkworks-crow SM-J810G

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

By adding this feature user can directly know that he did not have to give the null value in edit text or else he has to select the preference once again then he has to edit and save
By making default hotspot name as the device name so it will be like unique

GIF

Before submitting this PR, please make sure you have:

• run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.

[huangyz0918]

We should use some names that can indicate the class usage, not just CustomEditTextPreference @Chromicle .

[ajay-prabhakar]

I gave that name because maybe it will be useful for further implementations of any features

[huangyz0918]

I'm not sure do we really need a custom preference for this tiny check? @Chromicle

Can we use some method like,

private void checkNullEditTextPreference(EditTextPreference edttxtpref) {
    edttxtpref.setOnPreferenceChangeListener(new OnPreferenceChangeListener() {
        @Override
        public boolean onPreferenceChange(
                android.preference.Preference preference, Object newValue) {
            if (newValue.toString().trim().equals("")) {

              // Get Dialog and disable button here

                return false;
            }
            return true;
        }
    });
}

and receiving a EditTextPreference? You know, building a custom class is always a heavy work and not good for code reading and code refactoring. I didn't test for this method but you can have a try.

[ajay-prabhakar]

As far as I know, setOnPreferenceChangeListener will be triggered when we press the positive button of the dialog so there is no use if we disable the button then so, here we want to check the edit text for every time so we have to implement the editText watcher correct me if I am wrong

Now I updated the code without implementing the customEditTextPreference can please have a look now and thanks for your suggestions 😄

[lakshyagupta21]

There is no need to create a string resources for space.

[lakshyagupta21]

If this should just be a device odk-skunkworks-crow or the device name. Not a combination of both because if try to keep both the combinations, then it may get bigger for few devices then it may end up truncating or creating a double line for displaying just the name of the bluetooth/hotspot device.

[ajay-prabhakar]

can we go with device name