This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Removed redundant tab#333
Open
KomoderHell wants to merge 1 commit into
Open
Conversation
Author
|
@lakshyagupta21 this PR is failing the first test, and i am unable to figure out the problem. will you please look into the matter and review this PR |
Contributor
|
@SujayKaushik008 Did you run |
Author
|
@lakshyagupta21 sir, I did as you said the report says that a number of my files are deprecated and will be removed in PMD 7.0.0 . I have not done any changes in the files mentioned in this report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
How does this change affect users?
previously received and reviewed tabs showed similar sets of data, the received tab was used to approve forms whereas reviewed tab was used to send reviewed forms. In this work i merged the functionalities of both the tabs into one by making a few changes and removed the redundant reviewed tab, the user can now approve forms as well as send approved forms from received tab.
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes