Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Removed redundant tab#333

Open
KomoderHell wants to merge 1 commit into
getodk:masterfrom
KomoderHell:Issue179
Open

Removed redundant tab#333
KomoderHell wants to merge 1 commit into
getodk:masterfrom
KomoderHell:Issue179

Conversation

@KomoderHell

@KomoderHell KomoderHell commented Jan 7, 2020

Copy link
Copy Markdown

Closes #179

How does this change affect users?

previously received and reviewed tabs showed similar sets of data, the received tab was used to approve forms whereas reviewed tab was used to send reviewed forms. In this work i merged the functionalities of both the tabs into one by making a few changes and removed the redundant reviewed tab, the user can now approve forms as well as send approved forms from received tab.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.

@KomoderHell

Copy link
Copy Markdown
Author

@lakshyagupta21 this PR is failing the first test, and i am unable to figure out the problem. will you please look into the matter and review this PR

@lakshyagupta21

Copy link
Copy Markdown
Contributor

@SujayKaushik008 Did you run ./gradlew checkCode before pushing the commit, it looks like pmd check is failing you can run this in your terminal and look at the pmd report generated at the end.

@KomoderHell

Copy link
Copy Markdown
Author

@lakshyagupta21 sir, I did as you said the report says that a number of my files are deprecated and will be removed in PMD 7.0.0 . I have not done any changes in the files mentioned in this report

@qhb1001 qhb1001 mentioned this pull request Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant tab

2 participants