This repository was archived by the owner on Apr 9, 2021. It is now read-only.
fix: Fixed crash while sending forms through hotspot#324
Open
ajay-prabhakar wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@lakshyagupta21 can you please review and let me know if any changed required 😄 |
lakshyagupta21
approved these changes
Dec 3, 2019
lakshyagupta21
left a comment
lakshyagupta21
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Contributor
Author
|
I think you can merge this @lakshyagupta21, I tested everything and working fine |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #323
What has been done to verify that this works as intended?
Checked whether the crash is happening or not while sending the forms for the second time through hotspot transformation
Why is this the best possible solution? Were any other approaches considered?
As we are making local hotspot request once again so, checked whether the hotspot is initiated before we request for hotspot
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Crash is not the good behavior of the ideal app so, by fixing that user can directly send the forms
for a second time without restarting the app
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes