[MRG] Add reset settings option. by huangyz0918 · Pull Request #300 · getodk/skunkworks-crow

huangyz0918 · 2019-08-15T00:38:13Z

Closes #299

What has been done to verify that this works as intended?

Test using my Nexus 6P

Screenshots,

Why is this the best possible solution? Were any other approaches considered?

I only reset the settings, reset related to forms can be done by Collect, so we don't need to build a duplicate feature.

Note, the arrange of preference items will be improved by #290 , that includes some groups.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

N/A

Before submitting this PR, please make sure you have:

run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
verified that any code or assets from external sources are properly credited in comments and/or in the about file.

huangyz0918 · 2019-08-18T04:40:23Z

Now the dialog looks like

lakshyagupta21

Everything looks good to me, there are few string resources which needs improvements, please fix those.

lakshyagupta21 · 2019-08-18T06:42:37Z

@huangyz0918 I've tested this and it looks like whenever I clear the saved forms the forms are still shown in the sent and received tabs of the blank forms

huangyz0918 · 2019-08-18T07:22:49Z

@huangyz0918 I've tested this and it looks like whenever I clear the saved forms the forms are still shown in the sent and received tabs of the blank forms

In the code you can see I just deleted all the files in share folder and create a new folder. The share related databases should be reset successfully. According to you comment, do you mean we should also clear the odk folder?

lakshyagupta21 · 2019-08-18T07:31:30Z

In the code you can see I just deleted all the files in share folder and create a new folder. The share related databases should be reset successfully. According to you comment, do you mean we should also clear the odk folder?

No, skunkworks-crow should not delete any of the things present in ODK folder.

I'm testing it again, it could be some problem at my end because I took a pull from master in your branch while testing because bluetooth was not working.

lakshyagupta21 · 2019-08-18T07:51:28Z

I'm testing it again, it could be some problem at my end because I took a pull from master in your branch while testing because bluetooth was not working.

There seems to be some issue with InMemory map that we've related to forms information.
Steps to reproduce the problem.

Transfer any filled form from one device to another.
After the transfer is a successful tap on a form which you sent.
Go to sent tab.
You'll see the form information is still shown in that tab.

I checked the tables and db are deleted.

huangyz0918 · 2019-08-18T07:57:20Z

be some issue with InMemory map

So it seems we should clear the cache in memory after resetting the forms? @lakshyagupta21

lakshyagupta21 · 2019-08-18T12:26:35Z

So it seems we should clear the cache in memory after resetting the forms? @lakshyagupta21

Hmm, or lets reset the state of variables in onResume, anyways we're not doing any high memory usage operation in MainActivity.

huangyz0918 · 2019-08-18T12:35:31Z

Hmm, or lets reset the state of variables in onResume, anyways we're not doing any high memory usage operation in MainActivity.

Sure, let me have a try.

huangyz0918 · 2019-08-19T11:00:45Z

@lakshyagupta21 How about restarting the application after resetting the application?

Restart code like

 Intent mainIntent = new Intent(this, MainActivity.class);
                    int mPendingIntentId = 0x130;
                    PendingIntent mPendingIntent = PendingIntent.getActivity(this, mPendingIntentId, mainIntent, PendingIntent.FLAG_CANCEL_CURRENT);
                    AlarmManager mgr = (AlarmManager) getSystemService(Context.ALARM_SERVICE);
                    mgr.set(AlarmManager.RTC, System.currentTimeMillis() + 100, mPendingIntent);
                    System.exit(0);

I updated the PR, and did some tests, after a restart we can get the right behavior.

lakshyagupta21 · 2019-08-19T11:25:07Z

@lakshyagupta21 How about restarting the application after resetting the application?

Restart code like

@huangyz0918 , Restarting the application is not the solution we've to modify the code in MainActivity, this could be a solution in the short term but it's not going to help us in the long term.

huangyz0918 · 2019-08-19T11:28:59Z

Restarting the application is not the solution we've to modify the code in MainActivity, this could be a solution in the short term but it's not going to help us in the long term.

I think a quick restart looks like exiting and starting MainActivity again, and can refresh the whole application, it's a good option, handling in MainActivity is not a good solution and I think we should not do that, that can only make the future refactoring harder.

lakshyagupta21 · 2019-08-19T11:34:20Z

I think a quick restart looks like exiting and starting MainActivity again, and can refresh the whole application, it's a good option, handling in MainActivity is not a good solution and I think we should not do that, that can only make the future refactoring harder.

I would still not advice you to write code for app restart, if this was a solution then it would be there in ODK-Collect right? There are some consequences that we should take care when we're thinking in the direction of restarting the app, for high-end device this could be fast but for low-end devices restarting the app may take some time because that would take some time to load resources, activity, creating the storage directory(in our case its not required but in future we may have some use case)
What if there is some other activity on top of MainActivity? Then how restarting is going to help, for now, this looks the easiest solution but not the perfect solution.

lakshyagupta21 · 2019-08-25T12:56:14Z

@huangyz0918 While testing this PR, I was able to see the crash in Android 4.4

08-25 18:24:46.806 2023-2023/org.odk.share E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.odk.share, PID: 2023
    java.lang.RuntimeException: Cannot create directory: /storage/sdcard0/share/metadata
        at org.odk.share.application.Share.createODKDirs(Share.java:68)
        at org.odk.share.views.ui.settings.SettingsActivity.resetData(SettingsActivity.java:291)
        at org.odk.share.views.ui.settings.SettingsActivity.startReset(SettingsActivity.java:255)
        at org.odk.share.views.ui.settings.SettingsActivity.lambda$resetApplication$4(SettingsActivity.java:238)
        at org.odk.share.views.ui.settings.-$$Lambda$SettingsActivity$2ZWiFMifxwXM4EoK8yD3UbokPPo.onClick(lambda)
        at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
        at android.os.Handler.dispatchMessage(Handler.java:110)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:5304)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:515)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:824)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:640)
        at dalvik.system.NativeStart.main(Native Method)

huangyz0918 · 2019-08-25T12:57:56Z

Cannot create directory: /storage/sdcard0/share/metadata

It seems we missed a / between sdcard and 0? @lakshyagupta21

lakshyagupta21 · 2019-10-04T03:12:01Z

@huangyz0918 Can you fix the above issue in the same PR.

huangyz0918 · 2019-10-04T13:36:41Z

Can you fix the above issue in the same PR.

Yes will do.

huangyz0918 added 2 commits August 15, 2019 08:33

✨ feat: add reset settings option.

0a6aa1b

🚑 quickfix: remove general items.

24a842b

huangyz0918 changed the title ~~Add reset settings option.~~ [MRG] Add reset settings option. Aug 15, 2019

lakshyagupta21 suggested changes Aug 15, 2019

View reviewed changes

huangyz0918 added 2 commits August 18, 2019 08:37

✨ feat: add options for resetting.

d7320ba

🚑 quickfix:

888d822

lakshyagupta21 suggested changes Aug 18, 2019

View reviewed changes

🚑 quickfix: fix the strings.

14fb94d

lakshyagupta21 suggested changes Aug 18, 2019

View reviewed changes

Comment thread skunkworks_crow/src/main/res/values/strings.xml Outdated

Comment thread skunkworks_crow/src/main/res/values/strings.xml Outdated

Comment thread skunkworks_crow/src/main/res/values/strings.xml Outdated

Comment thread skunkworks_crow/src/main/res/values/strings.xml Outdated

🚑 quickfix: fix the strings.

a7c3882

🚑 quickfix: resolved conflicts.

fdc74f3

lakshyagupta21 reviewed Aug 19, 2019

View reviewed changes

Comment thread skunkworks_crow/src/main/res/xml/preferences_menu.xml Outdated

🚑 quickfix: fixed the missed conflict tag.

794dd7c

huangyz0918 added 2 commits August 19, 2019 19:02

✨ feat: restart application after resetting.

1088a50

✨ feat: restart application after resetting.

1770d67

huangyz0918 mentioned this pull request Aug 19, 2019

UI doesn't update after updating the database #304

Closed

⏪ revert:

3e282e2

Conversation

huangyz0918 commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Before submitting this PR, please make sure you have:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huangyz0918 commented Aug 18, 2019

Uh oh!

lakshyagupta21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lakshyagupta21 commented Aug 18, 2019

Uh oh!

huangyz0918 commented Aug 18, 2019

Uh oh!

lakshyagupta21 commented Aug 18, 2019

Uh oh!

lakshyagupta21 commented Aug 18, 2019

Uh oh!

huangyz0918 commented Aug 18, 2019

Uh oh!

lakshyagupta21 commented Aug 18, 2019

Uh oh!

huangyz0918 commented Aug 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

huangyz0918 commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakshyagupta21 commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huangyz0918 commented Aug 19, 2019

Uh oh!

lakshyagupta21 commented Aug 19, 2019

Uh oh!

lakshyagupta21 commented Aug 25, 2019

Uh oh!

huangyz0918 commented Aug 25, 2019

Uh oh!

lakshyagupta21 commented Oct 4, 2019

Uh oh!

huangyz0918 commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

huangyz0918 commented Aug 15, 2019 •

edited

Loading

huangyz0918 commented Aug 18, 2019 •

edited

Loading

huangyz0918 commented Aug 19, 2019 •

edited

Loading

lakshyagupta21 commented Aug 19, 2019 •

edited

Loading

huangyz0918 commented Oct 4, 2019 •

edited

Loading