Use Java 17#32
Merged
Merged
Conversation
grzesiek2010
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to do a
./gradlew assembleReleasefrommaster, I gotI looked at Collect and Collect uses Java 17 for everything so I've matched that and verify I can release.
What has been done to verify that this works as intended?
./gradlew assembleReleaseand then tried on device.Why is this the best possible solution? Were any other approaches considered?
I considered setting the Kotlin jvm target instead but I'd rather match the versions we use for Collect.
Are there any risks to merging this code? If so, what are they?
Can't currently think of one!