Skip to content

deps: bump domainfront to h2-capable build (#9)#40

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-domainfront-h2
Jun 24, 2026
Merged

deps: bump domainfront to h2-capable build (#9)#40
myleshorton merged 1 commit into
mainfrom
fisk/bump-domainfront-h2

Conversation

@myleshorton

@myleshorton myleshorton commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Bumps github.com/getlantern/domainfront to the merged
domainfront#9
(v0.0.0-20260419161617-0bff0b2169f4v0.0.0-20260624004218-93591749d736).

Why

domainfront#9 makes the fronted round trip ALPN-aware: when the CDN edge
negotiates HTTP/2 (CloudFront, Aliyun, …), the request is now framed as HTTP/2
instead of speaking HTTP/1.1 over the h2 connection — which previously failed
with malformed HTTP response "\x00\x00\x12\x04...". kindling fronts through
domainfront, so this fixes h2 edges transparently.

It also carries domainfront's utls v1.7.1 → v1.8.2 bump, but that's a no-op
here: kindling already resolves utls to v1.8.2 (via dnstt), and its go 1.25.0
directive already satisfies v1.8.x's Go-1.24-native ML-KEM requirement.

Compatibility

domainfront's public API (New, Config, Provider, Masquerade,
ParseConfig, WithConfigURL) is unchanged — the h2 work was internal to its
round-trip path. So this is a transparent dependency update.

go.mod/go.sum change is limited to the domainfront version. go build ./...,
go vet ./..., and go test . all pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated dependencies to ensure system stability and compatibility.

Picks up getlantern/domainfront#9, which makes the fronted round trip
ALPN-aware: it now frames requests as HTTP/2 when the CDN edge negotiates
h2 (CloudFront, Aliyun, ...) instead of speaking HTTP/1.1 over an h2
connection and failing with "malformed HTTP response". Also pulls the
utls v1.8.2 bump that ships with it (already the version kindling
resolves, so no utls change here).

domainfront's public API (New/Config/Provider/Masquerade/ParseConfig/
WithConfigURL) is unchanged, so this is a transparent dependency update.
Build, vet, and tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 24, 2026 00:49
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c3294e72-df61-4451-bcf6-2b8653418bcb

📥 Commits

Reviewing files that changed from the base of the PR and between 9a360f6 and 8b8c5a8.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The go.mod file is updated to bump github.com/getlantern/domainfront from pseudo-version v0.0.0-20260419161617-0bff0b2169f4 to v0.0.0-20260624004218-93591749d736. No other dependencies or module metadata are changed.

Changes

domainfront Dependency Bump

Layer / File(s) Summary
domainfront version update
go.mod
github.com/getlantern/domainfront pseudo-version is updated to a newer commit dated 2026-06-24.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A single line changed, a module renewed,
The domainfront hops to a fresher commit pursued.
One plus, one minus, the simplest of arts,
A tiny update with the tidiest of hearts.
sniff sniff — smells like fresh June code! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: bumping the domainfront dependency to gain HTTP/2 support, which is the primary objective of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fisk/bump-domainfront-h2

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the github.com/getlantern/domainfront dependency to a newer pseudo-version that includes internal ALPN-aware HTTP/2 handling, intended to fix failures when a CDN edge negotiates h2 while the client previously attempted HTTP/1.1 framing.

Changes:

  • Bump github.com/getlantern/domainfront to v0.0.0-20260624004218-93591749d736.
  • Update go.sum checksums to match the new domainfront version.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates the required github.com/getlantern/domainfront pseudo-version.
go.sum Replaces old domainfront sum entries with sums for the bumped version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@myleshorton myleshorton merged commit 737fcff into main Jun 24, 2026
3 checks passed
myleshorton added a commit to getlantern/radiance that referenced this pull request Jun 24, 2026
- domainfront -> v0.0.0-20260624004218-93591749d736 (getlantern/domainfront#9):
  makes the fronted round trip ALPN-aware, framing requests as HTTP/2 when
  the CDN edge negotiates h2 (CloudFront, Aliyun, ...) instead of speaking
  HTTP/1.1 over the h2 connection and failing with a malformed response.
- kindling -> v0.0.0-20260624005117-737fcffe2860 (getlantern/kindling#40):
  the matching kindling bump, which also carries domainfront#9.

domainfront's public API is unchanged, so this is a transparent dependency
update. The kindling/* and config consumer packages build under both build
tag sets and the kindling tests pass.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
myleshorton added a commit to getlantern/lantern that referenced this pull request Jun 24, 2026
Propagates the HTTP/2 fronting fix down to the client:
- radiance    -> v0.0.0-20260624010426-955f5cbfe595 (getlantern/radiance#536)
- domainfront -> v0.0.0-20260624004218-93591749d736 (getlantern/domainfront#9, indirect)
- kindling    -> v0.0.0-20260624005117-737fcffe2860 (getlantern/kindling#40, indirect)
- lantern-box -> v0.0.95 (transitive; now required by radiance#536)

domainfront#9 makes the fronted round trip ALPN-aware — it frames requests
as HTTP/2 when the CDN edge negotiates h2 (CloudFront, Aliyun, ...) instead
of speaking HTTP/1.1 over the h2 connection and failing with a malformed
response. API-compatible. Ran go mod tidy and committed go.mod+go.sum
together so gomobile resolves lantern-box v0.0.95 (not a stale pin).

Verified: full Go build under the CI tag set (CGO_ENABLED=1, with_gvisor/
with_quic/with_wireguard/with_utls/with_grpc/with_conntrack), go vet, and
lantern-core tests all pass.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants