Keep locked API access controls usable - #292
Open
webdevtodayjason wants to merge 1 commit into
Open
webdevtodayjason wants to merge 1 commit into
webdevtodayjason wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262
Problem
The API access panel could trust cached signed-in browser state even when /api/auth/status said the current request was unauthenticated. That stale state exposed Stop requiring a key, but the server correctly rejected the click.
Decision
Treat the server authenticated flag as the authority for the panel state, the disable control, and whether the key-entry details start open. Replace the source-text assertion with a Node behavior test that renders locked, stale-user, and authenticated states against the real app.js method.
Proof
Changelog: Fix the API access panel so locked browsers only get usable key-entry controls.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.