Skip to content

chore: update alby dependencies#435

Merged
im-adithya merged 1 commit into
masterfrom
chore/update-alby-dependencies
May 21, 2026
Merged

chore: update alby dependencies#435
im-adithya merged 1 commit into
masterfrom
chore/update-alby-dependencies

Conversation

@rolznz

@rolznz rolznz commented May 20, 2026

Copy link
Copy Markdown
Member

Note: in iOS I noticed some button padding issues in my local build (the map and settings buttons on the homepage), which should be unrelated to this PR.

Summary by CodeRabbit

  • Chores
    • Updated @getalby/lightning-tools to version 8.1.1
    • Updated @getalby/sdk to version 8.0.1

Review Change Stack

@rolznz rolznz requested a review from im-adithya May 20, 2026 07:20
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 71fc7c8d-477e-47bf-a549-ee7cd1a3356d

📥 Commits

Reviewing files that changed from the base of the PR and between fe92ea2 and 336068b.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • lib/state/appStore.ts
  • lib/utils.ts
  • package.json
  • pages/Transaction.tsx
  • pages/settings/wallets/ConnectWallet.tsx

📝 Walkthrough

Walkthrough

This PR modernizes module imports and upgrades dependencies. It converts @noble/hashes imports from CommonJS-compatible paths to ESM-compatible .js suffixes across the codebase, updates NIP-44 key derivation to encode the info parameter as UTF-8 bytes, and bumps @getalby/lightning-tools and @getalby/sdk to newer versions.

Changes

ESM Module Compatibility & Dependency Updates

Layer / File(s) Summary
Noble hashes ESM import updates
lib/state/appStore.ts, lib/utils.ts, pages/Transaction.tsx, pages/settings/wallets/ConnectWallet.tsx
Import paths for hexToBytes, bytesToHex, hkdf_extract, sha256, and utility helpers are updated from @noble/hashes/utils to @noble/hashes/utils.js and related module variants for ESM compatibility.
NIP-44 key derivation encoding
lib/utils.ts
getConversationKey passes the HKDF info parameter as UTF-8 encoded bytes via utf8ToBytes("nip44-v2") instead of the prior string form.
Getalby package version upgrades
package.json
@getalby/lightning-tools updated from ^6.0.0 to ^8.1.1 and @getalby/sdk updated from ^7.0.0 to ^8.0.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Module paths now dance with .js delight,
UTF-8 bytes encode the NIP-44 right,
Dependencies leap to versions new,
ESM harmony—a rabbit's debut! 📦

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change in the changeset, which is updating Alby dependencies (@getalby/lightning-tools and @getalby/sdk), though it omits the secondary import path updates which are implementation details.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-alby-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@im-adithya im-adithya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@im-adithya im-adithya merged commit 1ce5cd6 into master May 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants