Repository navigation
Conversation
brsbl
added this pull request to stack #5397
October 12, 2026 21:20
…ication-card-thr_gt5eeahuym
brsbl
removed this pull request from stack #5397
October 12, 2026 22:22
brsbl
added this pull request to stack #5407
October 12, 2026 22:22
brsbl
removed this pull request from stack #5407
October 12, 2026 22:23
brsbl
added this pull request to stack #5408
October 12, 2026 22:23
# Conflicts: # apps/web/src/routes/privacy.tsx # docs/configuration.md
brsbl
removed this pull request from stack #5408
October 12, 2026 22:53
brsbl
added this pull request to stack #5409
October 12, 2026 22:54
brsbl
removed this pull request from stack #5409
October 12, 2026 22:57
brsbl
added this pull request to stack #5410
October 12, 2026 22:57
…ication-card-thr_gt5eeahuym
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Notification permission needs a contextual invitation once a thread starts, with a durable way to decline it.
What changed
Show the shared sidebar card when a thread starts and browser permission is undecided. Request permission only after Notify me, remember dismissal, and record anonymous prompt outcomes through the setup telemetry route.
Extracted from #5222 without rewriting its history.
How you verified
Remote CI passed at
f87ca66bd323ec553c474641e8e3cf30dd47c3b0. Cumulative static review found no P0/P1 issues in this layer.QA PASS on that head in Chrome for Testing 154.0.8037.92: starting an offline Echo thread reveals the card and emits one strict
notification_prompt_shownevent; the card survives thread completion and hard reload. Dismissal survives reload. Notification permission staysdefaultuntil “Notify me” is clicked; a real browser denial recordsnotification_prompt_deniedand hides the card. No observed page errors. QA usedBB_TELEMETRY=false.Verified desktop light/dark and the open phone-width sidebar. The added privacy wording also renders correctly in Chrome and real Safari 26.5.2. Full-window captures use 2× density: desktop 1440 × 900 and phone-width 390 × 844. Compare parent
e21ae9dbd6with this head using the same persisted-card fixture.User screenshot sign-off remains pending. No merge requested.
BB-Thread-ID: thr_gt5eeahuym
BB-Thread: Onboarding