Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f82b04ba91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <button | ||
| type="button" | ||
| data-suggestion-card="" | ||
| aria-pressed={onSelect && !grouped ? selected : undefined} | ||
| aria-label={ariaLabel} | ||
| onClick={onSelect} |
There was a problem hiding this comment.
When onSelect is omitted, as it is for the thread and tip examples in the added story, this still renders an enabled, focusable <button> with pointer and hover styling. Keyboard and screen-reader users can therefore tab to and activate controls that do nothing. Make onSelect required for button cards, or render a non-interactive element when no callback is supplied.
Useful? React with 👍 / 👎.
…d-onboarding-components-thr_gt5eeahuym
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
1 participant
Human comments
What was wrong
The notification card, first-task suggestions, and related prompts need reusable UI pieces that can be reviewed and used independently.
What changed
Add
SidebarNudge,SuggestionCard, andInlineConfirmationto shared-ui, with registry entries and focused Ladle stories.Extracted from #5222 without rewriting its history.
How you verified
Remote CI passed at
7af427b8e457c69069631adf27feebbbe2bfa0cd(run). The cumulative review found no unresolved P0/P1 findings in this layer; the merge from main preserves the reviewed components.QA PASS at that exact head: Chrome for Testing 154.0.8037.92, production-component Ladle stories at 1440 × 900 and 390 × 844, 2× density. Verified initial rendering, card selection and inline confirmation, complete selection transition, hard reload and reset, light/dark nudge rendering, and no horizontal overflow or page errors. Story selection changes only fixture state.
Before: main
d34a3d219193d37bf4bb31b6b345dd113800c3f1; after: the PR head above. These are new components, so their story routes are absent on the baseline.User screenshot sign-off is pending.
BB-Thread-ID: thr_gt5eeahuym
BB-Thread: Onboarding