Repository navigation
Conversation
turn_finished is captured on the server when a root agent turn ends: on turn completion, on a provider process exit, and when a turn's start command fails. Each reports the outcome, a built-in provider id or "other", a coarse error category mapped from the provider's error classification (never error text), and whether this was the install's first finished turn. A one-time app-settings marker claims the first turn, and installs that already had several top-level threads never claim it. device_paired is added to the client telemetry allow-list. The server captures it when a new machine enrolls (not its own machine, not a re-enrollment), and the Push Notifications plugin reports it when a new iOS or Android device registers. Each carries only the device kind and whether it is the first of that kind. Both respect the usage-data opt-out. Privacy copy, configuration docs, the API audit entry, and the Push Notifications overview describe them. Plugin SDK 0.6.41. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ines Every turn end now reports from applyLoggedThreadLifecycleEvent beside the turn.failed announcement, deferred past the transaction. That covers server-settled stops, host disconnects, daemon restarts, and provisioning failures that never pass through event effects, and a fork seed settling from starting is not counted. The failure category comes from the latest system error since the turn started, else the provider's classification. The first-turn marker is claimed once per process instead of on every turn. device_paired for machines now fires only for join-code enrollments, so a fresh install no longer reports its own machine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The overview was already at the 4,000-character marketplace limit, so the usage-data note lives only in the privacy page and configuration docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Core no longer lists provider ids. turn_finished reports a provider id only when a bundled plugin's manifest declares it, so custom ACP agents and third-party providers still report as other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enrollHost returned only the host id, so the route could not tell a join-code enrollment from the server's own loopback one and never reported machines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… bb/turn-and-device-telemetry-thr_gqshddt6w2
… bb/turn-and-device-telemetry-thr_gqshddt6w2
… bb/turn-and-device-telemetry-thr_gqshddt6w2
brsbl
changed the title
Collaborator
Author
|
Superseded by #5438 on main-based native stack #5440. The replacement preserves this implementation, validated provider privacy fix, and review history. Final replacement CI is green at a96641c after moving the unchanged ACP-next tests to the sequential Windows host shard. Local event-shape evidence is linked there. This PR is closed without merging; its branch and history remain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Work events cannot reliably connect an accepted message to its turn, especially after queueing or retry.
What changed
How you verified
41e9b51b.654570f7; its provider privacy finding is fixed and validated without repeating the review.other.40972c58emitted both accepted message IDs onturn_startedandturn_finished. The original QA request used an incomplete expected queue prefix; correcting that fixture request completed the check.Recorded P2 follow-ups
start_failed.first_turnuses current root-thread count rather than historical first completion.BB-Thread: Retention measurement
BB-Thread-ID: thr_gqshddt6w2