Skip to content

GPS-745: switch to pnpm 11#1585

Open
KeeTraxx wants to merge 2 commits into
developfrom
fix_GPS-745_pnpm-upgrade
Open

GPS-745: switch to pnpm 11#1585
KeeTraxx wants to merge 2 commits into
developfrom
fix_GPS-745_pnpm-upgrade

Conversation

@KeeTraxx

@KeeTraxx KeeTraxx commented Jun 8, 2026

Copy link
Copy Markdown

@KeeTraxx KeeTraxx requested review from ltshb and schtibe June 8, 2026 11:10
@github-actions github-actions Bot added the bug label Jun 8, 2026
@cypress

cypress Bot commented Jun 8, 2026

Copy link
Copy Markdown

web-mapviewer    Run #6569

Run Properties:  status check passed Passed #6569  •  git commit e206d1e2b1: GPS-745: fix linting
Project web-mapviewer
Branch Review fix_GPS-745_pnpm-upgrade
Run status status check passed Passed #6569
Run duration 04m 58s
Commit git commit e206d1e2b1: GPS-745: fix linting
Committer Khôi Tran
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 222
View all changes introduced in this branch ↗︎

@KeeTraxx KeeTraxx force-pushed the fix_GPS-745_pnpm-upgrade branch from ea955bf to dbfd64a Compare June 9, 2026 06:45

@schtibe schtibe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pnpm-workspace.yaml
write-yaml-file: ^5.0.0
yaml: ^2.8.2
yargs: ^18.0.0
'@4tw/cypress-drag-drop': ^2.3.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to run prettier?

@KeeTraxx KeeTraxx force-pushed the fix_GPS-745_pnpm-upgrade branch from 414c4a0 to 50b4c7c Compare June 9, 2026 10:05
@KeeTraxx KeeTraxx force-pushed the fix_GPS-745_pnpm-upgrade branch 3 times, most recently from 7f225f9 to d8c4b33 Compare June 10, 2026 14:39
@KeeTraxx KeeTraxx force-pushed the fix_GPS-745_pnpm-upgrade branch from d8c4b33 to e206d1e Compare June 10, 2026 14:55
@KeeTraxx KeeTraxx requested a review from schtibe June 10, 2026 15:15
@KeeTraxx

Copy link
Copy Markdown
Author

@schtibe all tests are now green and it builds! Can you review again? I had to remove some 3D tests in the non-3d cypress tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants