ODM-13099: unable to create users from a file fix#632
Merged
egor-alexandrov merged 4 commits intoMay 19, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes issues around creating users from a TSV file (ODM-13099) by making the TSV reader and the create_users script more robust when optional columns/arguments are used.
Changes:
- Updated
TsvReaderto use the standard iterator protocol (__iter__/__next__) while keeping anextalias for compatibility. - Made the password column optional when reading users from TSV (auto-generates when missing/blank).
- Ensured
create_users.pybuilds the connection using the parsed CLI args (so extra script args don’t break connection parsing).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
odm_sdk/scripts/utils.py |
Standardizes iteration behavior for TSV reading (Python 3-friendly) while retaining compatibility. |
odm_sdk/scripts/users/create_users.py |
Allows TSV rows without an explicit password and fixes connection initialization to use parsed args. |
odm_sdk/files_util.py |
Minor docstring formatting tweak for the *names varargs parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-smazhevsky
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://genestack.atlassian.net/browse/ODM-13099