fix: improve repair instruction#1309
Merged
akihikokuroda merged 2 commits intoJun 22, 2026
Merged
Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
changed the title
akihikokuroda
changed the title
AngeloDanducci
approved these changes
Jun 22, 2026
AngeloDanducci
left a comment
AngeloDanducci
left a comment
Contributor
There was a problem hiding this comment.
One small optional nit, LGTM.
| f"Your code didn't save the plot to the expected file. " | ||
| f"Try: Add plt.savefig('{expected_path}') before plt.show() or plt.close()." | ||
| f"Try: Add plt.savefig('{expected_path}') before plt.show() or plt.close(). " | ||
| f"Do not use a variable as an argument of plt.savefig. Use a string literal as the argument like plt.savefig('{expected_path}'). " |
Contributor
There was a problem hiding this comment.
May be worth updating these two tests,
test_matplotlib_plot_file_saved_error_formatting
test_matplotlib_plot_file_saved_error_with_custom_path
to include: assert "string literal" in formatted or assert "Do not use a variable as an argument" in formatted.
Adding the assert would act as a safeguard if this gets changed in the future and cause a test failure/update required in case it is overlooked in a future update.
Otherwise LGTM!
Member
Author
There was a problem hiding this comment.
Thanks! I'll fix the tests..
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
generative-computing:main
with commit Jun 22, 2026
e718b60
14 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1308
Description
Improve the repair hint string to make LLM generate the code meet requirement validation.
It instructs to generate code like following
instead of
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.