-
Notifications
You must be signed in to change notification settings - Fork 129
feat(thunk): add .parsed property to ComputedModelOutputThunk for structured output #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
acb02f9
feat(thunk): add .parsed property to ComputedModelOutputThunk for str…
planetf1 0f77a9f
fix(thunk): propagate _format through __copy__/__deepcopy__; add Rais…
planetf1 83295e9
nit(thunk): soften parsed docstring example comment
planetf1 0c3498a
fix(thunk): wire _format in HF chat post_processing; add missing tests
planetf1 4857a32
nit(test): explain subclass-loss caveat in copy/deepcopy _format tests
planetf1 5aa6921
fix(types): make ComputedModelOutputThunk.parsed generic over the for…
planetf1 6118cea
fix(types): use concrete _format type and non-string cast for pyright…
planetf1 87b4b2f
docs(thunk): tighten .parsed and ComputedModelOutputThunk.value docst…
planetf1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| """Mypy / pyright checks that `ComputedModelOutputThunk.parsed` tracks the type parameter. | ||
|
|
||
| `.parsed` is typed `S | None`, so a thunk parameterized with a Pydantic model | ||
| (`ComputedModelOutputThunk[MyModel]`) exposes `.parsed` as `MyModel | None` — | ||
| callers need no `cast()`. The `format=` overloads in `session.py` / | ||
| `functional.py` bind `S` to the format model (companion issue #1274), at which | ||
| point these checks hold end-to-end from the call site. | ||
|
|
||
| The `cast(X, cast(object, None))` idiom creates a typed stub value without | ||
| triggering basedpyright's ``reportInvalidCast`` rule (direct ``cast(X, None)`` | ||
| raises that diagnostic because ``None`` and ``X`` share no overlap). | ||
| """ | ||
|
|
||
| from typing import assert_type, cast | ||
|
|
||
| import pydantic | ||
|
|
||
| from mellea.core import ComputedModelOutputThunk | ||
|
|
||
|
|
||
| class _Person(pydantic.BaseModel): | ||
| name: str | ||
|
|
||
|
|
||
| def check_parsed_tracks_format_model() -> None: | ||
| thunk = cast(ComputedModelOutputThunk[_Person], cast(object, None)) | ||
| _ = assert_type(thunk.parsed, _Person | None) | ||
|
|
||
|
|
||
| def check_parsed_is_str_for_str_thunk() -> None: | ||
| thunk = cast(ComputedModelOutputThunk[str], cast(object, None)) | ||
| _ = assert_type(thunk.parsed, str | None) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.