Fix NaN phydro#292
Draft
fabern wants to merge 20 commits into
Draft
Conversation
Previous commits introduced a new input parameter gw_calib. To respect the testing with continuous integration any change should include updating of the - vignettes/*.Rmd - tests/testthat/*.R - and documentation - data/*.rda Ideally this would be done in the same commit as the change to the model itself. Note that steps 1 and 2 can be tested locally with devtools::build_vignettes() and with devtools::test()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently still underway to be debugged (issue #290) and thus the PR is in draft status.
The files added are a MWE to reproduce the issue and setting up GUI debugging using VSCode.
Note also, that this already includes changes from
gw_calib. That PR #287 should be merged prior to this.