Skip to content

Update cspdk 0.17.0#27

Merged
joamatab merged 4 commits into
mainfrom
update_cspdk_0.17.0
May 12, 2025
Merged

Update cspdk 0.17.0#27
joamatab merged 4 commits into
mainfrom
update_cspdk_0.17.0

Conversation

@joamatab

@joamatab joamatab commented May 12, 2025

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Update core dependencies, refresh pre-commit tooling, and adjust training notebook for compatibility with Python 3.12 and pathlib-based file handling

Enhancements:

  • Bump cspdk dependency to 0.17.0 and gdsfactoryplus to >=0.46.1
  • Upgrade the ruff pre-commit hook to v0.11.0
  • Modify the gdsfactory-training notebook to use pathlib for S-parameter file paths and update kernel display name and Python version

Build:

  • Regenerate uv.lock to reflect updated dependencies

@sourcery-ai

sourcery-ai Bot commented May 12, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR upgrades cspdk to v0.17.0 (and gdsfactoryplus to v0.46.1), refreshes the lockfile, updates the example notebook to use pathlib for S-parameter exports and modernizes its kernel metadata, and bumps the Ruff pre-commit hook to v0.11.0.

File-Level Changes

Change Details Files
Enhanced the example notebook for path handling and metadata consistency
  • Added a pathlib import and blank line
  • Refactored write_sparameters call to wrap filepath with pathlib.Path
  • Updated kernelspec display_name and Python version metadata
examples/notebooks/gdsfactory-training/30_mzi.ipynb
Bumped project dependencies and regenerated lockfile
  • Updated cspdk requirement from 0.16.1 to 0.17.0
  • Updated gdsfactoryplus requirement from 0.42.2 to 0.46.1
  • Refreshed uv.lock to reflect updated dependencies
pyproject.toml
uv.lock
Upgraded the Ruff pre-commit hook
  • Bumped ruff hook revision from v0.8.4 to v0.11.0
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab merged commit 20b60a6 into main May 12, 2025
@joamatab joamatab deleted the update_cspdk_0.17.0 branch May 12, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant