broker: fix data race from leaked goroutine in fragment store health test#481
Merged
Merged
Conversation
…test TestFragmentStoreHealthCases created a broker via newTestBroker but never called cleanup(), so its resolver watch goroutine outlived the test. When a subsequent test called SetSharedPersister, the leaked goroutine was still reading the sharedPersister global in newReplica, tripping the race detector under `go test -race`. Add the missing `defer broker.cleanup()` to tear down the broker's tasks.Group at end of test, matching every other broker test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestFragmentStoreHealthCases created a broker via newTestBroker but never called cleanup(), so its resolver watch goroutine outlived the test. When a subsequent test called SetSharedPersister, the leaked goroutine was still reading the sharedPersister global in newReplica, tripping the race detector under
go test -race.Add the missing
defer broker.cleanup()to tear down the broker's tasks.Group at end of test, matching every other broker test.