Skip to content

Add an integration test for node deletion - #1126

Merged
gardener-prow[bot] merged 6 commits into
gardener:masterfrom
aaronfern:node_del_it
Sep 23, 2026
Merged

Add an integration test for node deletion#1126
gardener-prow[bot] merged 6 commits into
gardener:masterfrom
aaronfern:node_del_it

Conversation

@aaronfern

@aaronfern aaronfern commented Jul 27, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
This PR add an integration test to verify if machine deletion happens when node deletion is triggered

Which issue(s) this PR fixes:
Fixes partially #1123

Special notes for your reviewer:

Release note:

Added an integration test to validate machine deletion when it's corresponding node is deleted

@aaronfern
aaronfern requested a review from a team as a code owner July 27, 2026 13:03
@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2026
@aaronfern aaronfern added kind/test Test and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2026
@gardener-prow gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 27, 2026
@aaronfern aaronfern mentioned this pull request Jul 27, 2026
Open
5 of 6 tasks
thiyyakat
thiyyakat reviewed Aug 7, 2026
View reviewed changes

@thiyyakat thiyyakat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! The test looks good to me. I just had a few questions about possible behaviour.

Comment thread go.mod Outdated
Comment thread pkg/test/integration/common/framework.go Outdated
Comment thread pkg/test/integration/common/framework.go Outdated
Comment thread pkg/test/integration/common/framework.go Outdated
@gardener-prow gardener-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2026
gagan16k
gagan16k reviewed Aug 28, 2026
View reviewed changes
Comment thread pkg/test/integration/common/framework.go Outdated
takoverflow
takoverflow reviewed Sep 8, 2026
View reviewed changes
Comment thread pkg/test/integration/common/framework.go Outdated
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2026
takoverflow
takoverflow reviewed Sep 11, 2026
View reviewed changes
Comment thread pkg/test/integration/common/framework.go Outdated
@gardener-prow gardener-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2026
@gardener-prow gardener-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2026
takoverflow
takoverflow reviewed Sep 22, 2026
View reviewed changes
Comment thread pkg/test/integration/common/helpers/machine_resources.go Outdated
@aaronfern
Add an integration test for node deletion
57eb117 
Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@aaronfern
Address review comments
d4588eb 
Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@aaronfern
Address review feedback
e9355fd 
Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@aaronfern
Address review feedback
1915228 
Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2026
takoverflow
takoverflow reviewed Sep 22, 2026
View reviewed changes

@takoverflow takoverflow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2026
@gardener-prow

gardener-prow Bot commented Sep 22, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 9f43e07b3041d2c65c633efad09bf7042f721558

gagan16k
gagan16k reviewed Sep 23, 2026
View reviewed changes
Comment thread pkg/test/integration/common/helpers/machine_resources.go Outdated
@aaronfern
Pass mc names as parameter to CreateMachines
657efab 
Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@gardener-prow gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2026
@gagan16k

gagan16k commented Sep 23, 2026

Copy link
Copy Markdown
Member

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2026
@gardener-prow

gardener-prow Bot commented Sep 23, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: ea98bbcedebc5fa451c97016c718b603dccb5356

thiyyakat
thiyyakat reviewed Sep 23, 2026
View reviewed changes
Comment thread pkg/test/integration/common/framework.go Outdated
@aaronfern
Update comment that referred to virtual provider instead of simulated…
9b69984 
… provider

Signed-off-by: aaronfern <aaron.francis.fernandes@sap.com>
@gardener-prow gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2026
@thiyyakat

thiyyakat commented Sep 23, 2026

Copy link
Copy Markdown
Member

/lgtm

Thanks for the changes!

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2026
@gardener-prow

gardener-prow Bot commented Sep 23, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 3274063adb12aef26c2510535dae2a1273a2e0ef

takoverflow
takoverflow approved these changes Sep 23, 2026
View reviewed changes

@takoverflow takoverflow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow

gardener-prow Bot commented Sep 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: takoverflow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2026
@gardener-prow
gardener-prow Bot merged commit 9dcf218 into gardener:master Sep 23, 2026
13 checks passed
@gagan16k gagan16k mentioned this pull request Sep 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagan16k gagan16k gagan16k left review comments
@thiyyakat thiyyakat thiyyakat left review comments
@takoverflow takoverflow takoverflow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/test Test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronfern @gagan16k @thiyyakat @takoverflow