Skip to content
This repository was archived by the owner on Jul 25, 2022. It is now read-only.

auto update#484

Open
tedteng wants to merge 1 commit into
gardener-attic:masterfrom
tedteng:gardenctl_update
Open

auto update#484
tedteng wants to merge 1 commit into
gardener-attic:masterfrom
tedteng:gardenctl_update

Conversation

@tedteng

@tedteng tedteng commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
enable gardenctl auto-update

Which issue(s) this PR fixes:
Fixes #482

Special notes for your reviewer:

Release note:

gardenctl able to auto upgrade -  `gardenctl update`

@tedteng tedteng requested a review from a team as a code owner December 4, 2020 07:25
@ghost ghost added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 4, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 4, 2020
Comment thread pkg/cmd/update-check.go
if err != nil {
log.Fatal(err)
}
download(out, "https://github.com/gardener/gardenctl/releases/download/"+latestVersion+"/gardenctl-darwin-amd64")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not do this.
I am a linux user and this will not work for me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information. I will add extra logic for both user

@ghost ghost added the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label May 19, 2021
@github-actions

github-actions Bot commented Jul 6, 2021

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ghost ghost added the needs/rebase Needs git rebase label Sep 7, 2021
@ghost

ghost commented Sep 7, 2021

Copy link
Copy Markdown

@tedteng You need rebase this pull request with latest master branch. Please check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review PR: needs rebase size/s Size of pull request is small (see gardener-robot robot/bots/size.py)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gardenctl update enhancement.

3 participants