Repository navigation
Small-follow-up PR with more details on trigger histogram comparison - #45
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Scope inventories need to include reported SSTS metrics, and telescope-type deviations need explicit page-link handling.
1 open finding
What changed in this PR
Adds detailed trigger-histogram acceptance-deviation reports, scope inventories, and release-summary links for v0.39.0.
Changes:
- Adds north and south metric-scope inventories.
- Adds deviation listings with report references.
- Updates release summaries and metadata.
| File | Description |
|---|---|
simtools-tests/v0.39.0/science_tests/reports/south/compare.trigger_histograms/comparison_inventory.json |
Adds South metric scopes. |
simtools-tests/v0.39.0/science_tests/reports/south/compare.trigger_histograms/acceptance.md |
Lists South acceptance deviations. |
simtools-tests/v0.39.0/science_tests/reports/release-summary.md |
Links detailed deviation reports. |
simtools-tests/v0.39.0/science_tests/reports/release-summary.json |
Updates report metadata. |
simtools-tests/v0.39.0/science_tests/reports/north/compare.trigger_histograms/comparison_inventory.json |
Adds North metric scopes. |
simtools-tests/v0.39.0/science_tests/reports/north/compare.trigger_histograms/acceptance.md |
Lists North acceptance deviations. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more detailed listing of comparison tests which fails the acceptance thresholds, including links to page numbers.