Repository navigation
Testing science-test configuration in the CI. - #43
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Publish or pin the required science-test schemas before enabling these CI checks.
1 open finding
What changed in this PR
Adds CI validation for science-test configuration files and HTCondor environment settings using simtools schemas.
Changes:
- Extends schema mappings and validation checks.
- Adds HTCondor environment validation.
- Documents the new CI coverage.
| File | Summary |
|---|---|
docs/changes/43.feature.md |
Documents the new validation feature. |
.github/workflows/CI-schema-validation.yml |
Adds science-test and HTCondor schema checks; referenced science-test schemas are unavailable in the installed simtools version. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.