Enforce unique, nonempty labels for strategies#981
Merged
Conversation
Member
|
I've added a commit that ensures generation of a unique strategy label in the GUI. However, I noticed duplicate strategy labels are not being checked on creating new strategies. |
tturocy
requested changes
Jul 9, 2026
tturocy
requested changes
Jul 9, 2026
| if (p_player->GetGame().get() != this) { | ||
| throw MismatchException(); | ||
| } | ||
| auto strategy = |
Member
There was a problem hiding this comment.
Same comment as made on the player PR - the point of having a label that is required on initialisation is to provide a valid one.
tturocy
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Description of the changes in this PR
Enforces label rules for strategies, following the same pattern as players. Strategies are a nonempty, unique-within-player scope, enforced in
GameStrategyRep::SetLabel:ValueError.add_strategynow requires a label (no default, no auto-generation).