BasicAuth for PulsarTesRunner#391
Merged
Merged
Conversation
Member
|
@BorisYourich this CI error seems relevant: |
Member
|
I've been on a Pulsar hiatus but this PR looks great to me. Any chance you can rebase and see if it resolves the type error? |
Added private_token destination and Headers for OAuth2 Authorization in Tes client as was done in pydantic-tes TesClient .
Options for job_conf should be:
auth: "none","Basic" ("oauth2" in the future)
username:
password:
Member
|
Thank you so much - sorry for the delays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements basic authorisation functionality in job submission to TES server.
Job configuration is extended by following options:
Following this approach the OAuth2 authorisation could be implemented, although it requires an implementation of underlying mechanism that would obtain and refresh service tokens from the configured authority.
This PR is dependent on PR#5 in pydantic-tes