Fix Soundcloud track duration rendering for long tracks#2
Merged
Conversation
|
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
For tracks longer than an hour (e.g. DJ mixes on Soundcloud), the remaining-time label rendered as
-1:23:45overflowed the 50pt fixed-width frame and SwiftUI wrapped the last digit to a second line.Fix: drop
lineLimit(1)andfixedSize(horizontal: true, vertical: false)on both time labels, and switch the frame constraints fromwidth:tominWidth:so the seek bar stays at a consistent width for normal-length tracks but the label can expand without wrapping for long ones.