Fix: Multiline Entry ignores scroll position on mobile TouchDown (#6307)#6417
Merged
Merged
Conversation
andydotxyz
previously approved these changes
Jul 16, 2026
andydotxyz
left a comment
Member
There was a problem hiding this comment.
Excellent catch, thanks so much for the clean fix
Fixing the whitespace
Member
|
Just applying a whitespace fix to try and get this passing CI |
andydotxyz
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
TouchDowninwidget/entry.gowas directly readingev.Positionwithout accounting for the internal scroll offset. This caused the cursor to jump to the wrong line on mobile devices when a multiline entry was scrolled.This patch mirrors the existing desktop
MouseDownlogic by addinge.scroll.Offsetto the tap coordinates, ensuring the cursor lands exactly where the user taps.Additionally, I added
TestEntry_TouchDown_AccountsForScrollin a new internalwidget/entry_touch_test.gofile to prevent future regressions.Fixes #6307
Checklist: