Skip to content

fix: add additional traceback to exception#135

Merged
ashwin1111 merged 1 commit into
masterfrom
additional-traceback
Apr 20, 2026
Merged

fix: add additional traceback to exception#135
ashwin1111 merged 1 commit into
masterfrom
additional-traceback

Conversation

@ashwin1111

@ashwin1111 ashwin1111 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved error messages to include response details for better debugging and troubleshooting.

@github-actions

Copy link
Copy Markdown

PR description must contain a link to a ClickUp (case-insensitive)

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Updated the SageIntacctSDKError.__str__ method to include the stored response value in error string representations, and bumped the package version from 1.28.0 to 1.28.1.

Changes

Cohort / File(s) Summary
Error Representation
sageintacctsdk/exceptions.py
Modified SageIntacctSDKError.__str__ to return formatted string including both message and response details instead of only the message.
Version Update
setup.py
Incremented package version from 1.28.0 to 1.28.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A message once shy, now speaks full and true,
With response details bundled into view,
Version bumped gently, from point-eight to one,
Error messages richer—much better done!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to add 'additional traceback to exception', but the actual changes update the exception's string representation to include response details, not traceback information. Revise the title to accurately reflect the change, such as 'fix: include response details in exception string representation' or 'fix: enhance exception error message with response data'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch additional-traceback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

PR description must contain a link to a ClickUp (case-insensitive)

@ashwin1111 ashwin1111 merged commit 83cc868 into master Apr 20, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants