Fix subscription refresh cache fallback and peek classification#940
Open
actx4gh wants to merge 1 commit into
Open
Fix subscription refresh cache fallback and peek classification#940actx4gh wants to merge 1 commit into
actx4gh wants to merge 1 commit into
Conversation
Correct cached subscription task deduplication so the first cached task for a channel contributes its cache pager and later duplicate cache tasks are skipped. Avoid propagating exceptions from successful cache fallback results, preventing one transient channel/network failure from aborting collection of the remaining subscription refresh results. Also fix peek-task classification precedence so the peek setting and client capability checks apply consistently.
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
Author
/recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct cached subscription task deduplication so the first cached task for a channel contributes its cache pager and later duplicate cache tasks are skipped.
Avoid propagating exceptions from successful cache fallback results, preventing one transient channel/network failure from aborting collection of the remaining subscription refresh results.
Also fix peek-task classification precedence so the peek setting and client capability checks apply consistently.
Related to #922
Related to #915
May also help #880
May also help #539
May also help #544