refactor(scaffold): base URL generation and content hashing#2261
Conversation
|
🤖 Finished Review · ✅ Success · Started 7:30 PM UTC · Completed 7:40 PM UTC |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Info
Previous runReviewFindingsMedium
Low
Info
Previous runReviewFindingsLow
Info
Previous run (2)ReviewFindingsLow
Info
Previous runReviewFindingsMedium
Low
Info
Previous run (2)ReviewFindingsLow
Info
Previous run (3)ReviewFindingsLow
Info
Previous run (4)ReviewFindingsLow
Info
|
9bcba6d to
f75a820
Compare
Site previewPreview: https://f0fc77df-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:50 PM UTC · Completed 8:02 PM UTC |
ralphbean
left a comment
There was a problem hiding this comment.
LGTM. One thing on the commit type — this adds internal library functions with no user-facing behavior change, so per COMMITS.md it should be refactor(scaffold) rather than feat(scaffold). GoReleaser uses feat commits to populate the Features section of release notes, and this isn't something an end user would recognize as new capability. Worth updating the PR title and commit message before merge.
f75a820 to
6d3c538
Compare
|
🤖 Review · |
6d3c538 to
69d3dbd
Compare
|
🤖 Finished Review · ✅ Success · Started 1:03 PM UTC · Completed 1:15 PM UTC |
…arness templates Add infrastructure for generating integrity-verified base URLs pointing to upstream scaffold harness templates. This is the foundation for PR 4 (install generates thin wrapper harnesses with base: references). ADR-0045 Phase 2, PR 3. Signed-off-by: Greg Allen <gallen@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
69d3dbd to
f21436b
Compare
|
🤖 Finished Review · ✅ Success · Started 2:07 PM UTC · Completed 2:19 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 2:30 PM UTC · Completed 2:38 PM UTC |
Retro: PR #2261 —
|
Summary
ScaffoldBaseURL,ScaffoldContentHash,ScaffoldBaseURLWithHash, andScaffoldHarnessNamesto the scaffold packageraw.githubusercontent.combase URLs for embedded harness templates, with#sha256=...fragmentsbase:references)ADR-0045 Phase 2, PR 3. See
docs/plans/adr-0045-forge-portable-harness-phase2.md.Test plan
ScaffoldBaseURLvalidates harness name (^[a-z][a-z0-9_-]*$) and commit SHA (40-char hex)ScaffoldContentHashreturns correct SHA-256 of embedded content; verified against manual computationScaffoldBaseURLWithHashproduces valid URL with integrity hash fragmentScaffoldHarnessNamesreturns all 6 harnesses sorted alphabeticallygo vetandmake lintclean🤖 Generated with Claude Code