docs(#2215): extend forge abstraction scope to action.yml#2219
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#2215): extend forge abstraction scope to action.yml#2219fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Site previewPreview: https://08a2d1b1-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 12:11 PM UTC · Completed 12:18 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Info
Previous runReviewFindingsMedium
|
fullsend-ai-review
Bot
added
the
requires-manual-review
ralphbean
approved these changes
Jun 12, 2026
The forge abstraction rule in CLAUDE.md and AGENTS.md was written with Go-specific examples (exec.Command, net/http) and did not explicitly cover action.yml bash scripts. This led the code agent in PR #2150 to correctly use forge.Client in Go but also add parallel inline gh api calls in action.yml, requiring substantial rework. Both files now state that new GitHub API operations in action.yml steps should be implemented as fullsend CLI subcommands (under internal/cli/) that use forge.Client, not as inline gh api calls. Existing gh api calls are grandfathered but should be migrated when touched. Note: make lint could not run in sandbox due to shellcheck installation failure (network restriction). This is a docs-only change with no code to test. Closes #2215
ralphbean
force-pushed
the
agent/2215-forge-action-yml-scope
branch
from
e2ccaab to
38cfc04
Compare
|
🤖 Finished Review · ✅ Success · Started 5:49 PM UTC · Completed 5:58 PM UTC |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forge abstraction rule in CLAUDE.md and AGENTS.md was written with Go-specific examples (exec.Command, net/http) and did not explicitly cover action.yml bash scripts. This led the code agent in PR #2150 to correctly use forge.Client in Go but also add parallel inline gh api calls in action.yml, requiring substantial rework.
Both files now state that new GitHub API operations in action.yml steps should be implemented as fullsend CLI subcommands (under internal/cli/) that use forge.Client, not as inline gh api calls. Existing gh api calls are grandfathered but should be migrated when touched.
Note: make lint could not run in sandbox due to shellcheck installation failure (network restriction). This is a docs-only change with no code to test.
Closes #2215
Post-script verification
agent/2215-forge-action-yml-scope)9c19aa5cc7bd8f1d0d499453d12855e03c8b7f9c..HEAD)