Fix nuget download force#187
Open
Splaxi wants to merge 2 commits into
Open
Conversation
- Add fscCompileNugetForce setting (default $true) to keep the original force-download behaviour; set $false to reuse already downloaded packages and keep them during cleanup for faster repeated local builds. - Drive the compiler NuGet downloads and packages-folder cleanup off the new setting in Invoke-FSCCompile. - Fix Get-FSCPSNuget size comparison: read the blob size from the PSFSize '.Size' property instead of '.Length' (which returned 1 and forced a re-download every run), and log the correct local size. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to work with the new parallel parameters, I saw that it re-downloaded all nugets, over and over.
This changes helps to module stay with the current implementation, but allowing to override.
One could argue that the current implementation is incorrect...