CI: Fix dev flag#2707
Conversation
WalkthroughThe workflow file for building the frontend was updated. Instead of assigning environment variables directly, echo commands now append values—specifically for Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant ENV as $GITHUB_ENV
participant BUILD as Build Process
GH->>ENV: Echo NX_URL_GITHUB_GO_CURRENT_VERSION, NX_DAEMON, NX_SHOW_DEV_COMPONENTS
ENV-->>GH: Variables set
GH->>GH: Echo NX_SHOW_DEV_COMPONENTS (for non-gi-frontend)
GH->>BUILD: Execute build command
Assessment against linked issues
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/build-frontend.yml (2)
67-69: Consistent and Clear Environment Variable Setup!
The updated commands to append environment variables to$GITHUB_ENV(lines 67–69) are a solid improvement and align with GitHub Actions best practices. One tiny nitpick from a bleary-eyed mind: while line 67 wraps$GITHUB_ENVin quotes, lines 68 and 69 do not—consider quoting them for consistency and to safeguard against any unexpected whitespace issues.
75-77: Enhanced Debug Visibility in the Build Step
The echo ofNX_SHOW_DEV_COMPONENTSin the "Build other frontend" step (lines 75–77) is a nice touch for debugging, ensuring the value is as expected before kickoff. Just double-check whether this echo is meant for production clarity or if it was intended as a temporary debugging aid—clarity now saves groggy headaches later!
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-frontend.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: gen-file
- GitHub Check: typecheck
- GitHub Check: call-build / build
- GitHub Check: call-build / build
- GitHub Check: call-build / build
- GitHub Check: call-build / build
- GitHub Check: lint
- GitHub Check: call-build / build
- GitHub Check: test
|
[zzz-frontend] [Mon Feb 10 20:43:18 UTC 2025] - Deployed 58f5a01 to https://genshin-optimizer-prs.github.io/pr/2707/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Feb 10 20:43:39 UTC 2025] - Deployed 58f5a01 to https://genshin-optimizer-prs.github.io/pr/2707/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Feb 10 20:43:55 UTC 2025] - Deployed 58f5a01 to https://genshin-optimizer-prs.github.io/pr/2707/frontend (Takes 3-5 minutes after this completes to be available) [Mon Feb 10 20:47:04 UTC 2025] - Deleted deployment |
2 participants
Describe your changes
Issue or discord link
Testing/validation
Tested here nguyentvan7#33
https://nguyentvan7.github.io/genshin-optimizer/33/zzz-frontend/
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit