Custom Target Expressions#2184
Conversation
validateCustomExpression
Custom Functions prerelease 2 parseCustomExpression
Custom Functions, Finally
format
fix test & typecheck & format
|
I don't know why, but since this PR was published I have never encountered the optimizer refusing to work when I used CTE. |
Minimum (un)viable option. Slowly, very slowly...
Better, but still terribly slow...
Fix typecheck
Fix format
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When converting, an empty expression appeared.
# Conflicts: # libs/gi/db/src/Database/DataManagers/CustomMultiTarget.ts # libs/gi/db/src/Interfaces/CustomMultiTarget.ts # libs/gi/page-team/src/index.tsx # libs/gi/wr/src/api.ts
… legacy interface file - move CustomMultiTarget expression types/specs into DataManagers/CustomMultiTarget - re-export expression-related types and helpers from DataManagers index - remove obsolete libs/gi/db/src/Interfaces/CustomMultiTarget.ts - keep frontend and wr typecheck green after API export updates
…ages conflict Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Describe your changes
I added support for custom target expressions and a convenient editor.

Since the last PR I have found at least one indisputably correct way to use CTE.
Example: https://discord.com/channels/785153694478893126/1035719815622561892/1244630283052126298
Another example: https://discord.com/channels/785153694478893126/1035720633167921313/1237378233666633850
Testing/validation
The optimizer sometimes refuses to work with some large expressions. Like this:

This can be bypassed by slightly changing the form of the expression without changing the essence.

Also, this case is calculated incorrectly. Although when it is used as part of a larger expression, it is calculated as expected.

I can't fix it. It's an engine issue. I preferred to forget about it until the transition to Pando.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.