Skip to content

Custom Target Expressions#2184

Draft
aurceive wants to merge 91 commits into
frzyc:masterfrom
aurceive:master
Draft

Custom Target Expressions#2184
aurceive wants to merge 91 commits into
frzyc:masterfrom
aurceive:master

Conversation

@aurceive

@aurceive aurceive commented May 31, 2024

Copy link
Copy Markdown

Describe your changes

I added support for custom target expressions and a convenient editor.
image

Since the last PR I have found at least one indisputably correct way to use CTE.

Example: https://discord.com/channels/785153694478893126/1035719815622561892/1244630283052126298
Another example: https://discord.com/channels/785153694478893126/1035720633167921313/1237378233666633850

Testing/validation

The optimizer sometimes refuses to work with some large expressions. Like this:
image

This can be bypassed by slightly changing the form of the expression without changing the essence.
image

Also, this case is calculated incorrectly. Although when it is used as part of a larger expression, it is calculated as expected.
image

I can't fix it. It's an engine issue. I preferred to forget about it until the transition to Pando.

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@aurceive

Copy link
Copy Markdown
Author

I don't know why, but since this PR was published I have never encountered the optimizer refusing to work when I used CTE.
I also checked the example of the incorrect calculation, now it returns the expected result.

aurceive added 4 commits July 25, 2024 12:57
Minimum (un)viable option.
Slowly, very slowly...
Better, but still terribly slow...
@frzyc frzyc marked this pull request as draft November 11, 2024 21:54
@coderabbitai

coderabbitai Bot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5806c823-9419-4122-a4ca-6e9e8ef315f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

aurceive and others added 17 commits March 30, 2025 12:51
When converting, an empty expression appeared.
# Conflicts:
#	libs/gi/db/src/Database/DataManagers/CustomMultiTarget.ts
#	libs/gi/db/src/Interfaces/CustomMultiTarget.ts
#	libs/gi/page-team/src/index.tsx
#	libs/gi/wr/src/api.ts
… legacy interface file

- move CustomMultiTarget expression types/specs into DataManagers/CustomMultiTarget
- re-export expression-related types and helpers from DataManagers index
- remove obsolete libs/gi/db/src/Interfaces/CustomMultiTarget.ts
- keep frontend and wr typecheck green after API export updates
…ages conflict

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants